Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add disclaimer that maketx call is a state-changing call #2134

Merged
merged 2 commits into from
May 23, 2024
Merged

docs: add disclaimer that maketx call is a state-changing call #2134

merged 2 commits into from
May 23, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented May 17, 2024 •
edited

Description

After discussions in #1523, we decided to add a disclaimer to maketx call which will let people know that a call to Render() will appliy state changes.

Closes: #1523

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@leohhhn leohhhn requested a review from moul as a code owner May 17, 2024 09:08
@leohhhn leohhhn self-assigned this May 17, 2024
@leohhhn leohhhn requested review from zivkovicmilos and removed request for moul May 17, 2024 09:08
zivkovicmilos
zivkovicmilos requested changes May 17, 2024
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

Please change the block type 🙏

docs/gno-tooling/cli/gnokey.md Outdated Show resolved Hide resolved
@thehowl thehowl changed the title chore(docs): add disclaimer that maketx call is a state-changing call docs: add disclaimer that maketx call is a state-changing call May 23, 2024
@thehowl thehowl merged commit dc9acde into gnolang:master May 23, 2024
5 checks passed
@leohhhn leohhhn deleted the docs/minting-coins-in-render branch May 27, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehowl thehowl thehowl approved these changes

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

Assignees

@leohhhn leohhhn

Labels
None yet
Projects
👥 Team: Devrels
Status: Done
💪 Bounties & Worx
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] Minting coins in Render()
3 participants
@leohhhn @thehowl @zivkovicmilos