feat: Embed genesis files. #2129
Conversation
Proposal for embedding initial genesis data inside the gnoland binary instead of need them on the filesystem in the gnoroot folder. It will simplify docker images and in general install and execution process. Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
ajnavarro
requested review from
moul,
gfanton,
zivkovicmilos and
a team
as code owners
github-actions
bot
added
the
📦 ⛰️ gno.land
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2129 +/- ##
==========================================
+ Coverage 49.04% 49.08% +0.04%
==========================================
Files 576 576
Lines 77556 77570 +14
==========================================
+ Hits 38035 38079 +44
+ Misses 36439 36404 -35
- Partials 3082 3087 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
| // Initialize the zap logger | ||
| zapLogger := log.GetZapLoggerFn(logFormat)(io.Out(), logLevel) | ||
|
|
||
| // Wrap the zap logger | ||
| logger := log.ZapLoggerToSlog(zapLogger) | ||
|
|
||
| slog.SetDefault(logger) |
There was a problem hiding this comment.
Not sure about this. I don't care if we use the slog default logger, but we should use it consistently throughout or not use it at all. I don't want to mix slog.Default and non-default logger.
|
Not clear if these files are something we should embed into the bin, or completely avoid having them on the first place. |
|
This could be fine as an interim default, and I think we can merge this PR if you want @ajnavarro, but eventually these files should be removed with the chain initialization efforts (in test4). |
Proposal for embedding initial genesis data inside the gnoland binary instead of need them on the filesystem in the gnoroot folder.
It will simplify docker images and in general install and execution process.
When a gnoland node is started and no genesis files are specified, we will log a warning per genesis file indicating to the user that we are loading defaults.
Related with #2091
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description