feat: clean GRC721 implementation #2117
Open
+567
−1,914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
🧾 package/realm
|
LGTM to. As far as I'm concerned, there are no breaking changes. It's nice to have an implementation following the standard ERCs. I will update Flippando to use this realm once the PR is merged. |
This was referenced Jun 5, 2024
leohhhn
changed the title
|
after this PR is merged, i will update NFT's extensions realms @leohhhn |
deelawn
pushed a commit
that referenced
this pull request
Jun 6, 2024
<!-- please provide a detailed description of the changes made in this pull request. --> ## Description This PR removes the outdated (and full of mistakes) guide from the docs. After [this PR](#2117) is merged, we can add a create a new how-to guide on how to create a GRC721 token. I've added [an issue](#2288) about this. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
moul
reviewed
Jun 7, 2024
Comment on lines
+12
to
+16
| owners *avl.Tree // tokenID > std.Address | ||
| balances *avl.Tree // std.Address > # of owned tokens | ||
| tokenApprovals *avl.Tree // tokenID > std.Address | ||
| operatorApprovals *avl.Tree // "OwnerAddress:OperatorAddress" -> bool | ||
| tokenURIs *avl.Tree // tokenID > URI |
There was a problem hiding this comment.
since you've at least 3 elements sharing the same key, I suggest having a single avl.Tree but returning an object.
moul
reviewed
Jun 7, 2024
| nft.getApproved(tokenId) == owner | ||
| } | ||
|
|
||
| func (nft Token) update(to std.Address, tokenId string, auth std.Address) std.Address { |
There was a problem hiding this comment.
Suggested change
| func (nft Token) update(to std.Address, tokenId string, auth std.Address) std.Address { | |
| func (nft *Token) update(to std.Address, tokenId string, auth std.Address) std.Address { |
was the code currently working?
because it shouldn't.
moul
reviewed
Jun 7, 2024
| } | ||
| } | ||
|
|
||
| std.Emit("Transfer", "from", from.String(), "to", to.String(), "tokenID", tokenId) |
There was a problem hiding this comment.
Suggested change
| std.Emit("Transfer", "from", from.String(), "to", to.String(), "tokenID", tokenId) | |
| std.Emit("Transfer", | |
| "from", from.String(), | |
| "to", to.String(), | |
| "tokenID", tokenId, | |
| ) |
I suggest this format for emitted events, until we can have typesafe ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ported from here for visibility.
This is an experiment involving a refactor of the GRC721 package. The idea with this is that we might want a fully "by-spec" implementation, that people who know the standard can use out of the box.
The process for writing this was the following:
This PR replaces the old GRC721 implementation with the new one, and updates the
foo721example realm, and removes thenftexample realm to only have a single example implementation.Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description