-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gnovm): prevent cyclic references in struct declarations #2081
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2081 +/- ##
==========================================
+ Coverage 46.27% 52.00% +5.73%
==========================================
Files 483 388 -95
Lines 68851 63348 -5503
==========================================
+ Hits 31862 32946 +1084
+ Misses 34356 27729 -6627
- Partials 2633 2673 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This might be solvable by adding some logic in transcribe, without a dependency graph. This might be a better place than transcribe. var runDeclarationFor func(fn *FileNode, decl Decl) I don't know. Try it out and see what is the most appropriate place for this. |
This is great and proves to be the right way to go. It's already updated, please take a look @petar-dambovaliev . |
Address #2008.
In this pull request, we're implementing a special handling for struct declarations. Due to their unique nature, we must meticulously search through their fields to identify potential cyclic reference.
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description