Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(make): don't print bash comment #2080

Merged
merged 2 commits into from
May 28, 2024

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented May 13, 2024

Super minor change. Just added @ prefix to prevent shown out comment while run make.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@notJoon notJoon requested a review from a team as a code owner May 13, 2024 02:42
@notJoon notJoon requested review from petar-dambovaliev and harry-hov and removed request for a team May 13, 2024 02:42
@thehowl thehowl changed the title chore: Fix print out comment on Makefile chore(make): don't print bash comment May 28, 2024
@thehowl thehowl merged commit 3a031b3 into gnolang:master May 28, 2024
4 checks passed
omarsy pushed a commit to TERITORI/gno that referenced this pull request Jun 3, 2024
Super minor change. Just added `@` prefix to prevent shown out comment
while run make.

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

Co-authored-by: Morgan <morgan@morganbaz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants