DigiPots support #108
Open
DigiPots support #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnboiles
commented
Aug 15, 2019
| @@ -41,10 +41,10 @@ | |||
| // Define the Grbl system include files. NOTE: Do not alter organization. | |||
| #include "config.h" | |||
| #include "nuts_bolts.h" | |||
| #include "cpu_map.h" | |||
There was a problem hiding this comment.
I needed to move this up so that cpu_map.h got processed before settings.h so that settings.h could know if HAS_DIGIPOTS was defined
|
Hi @chamnit, do you think this feature should be merged into If yes, are you OK with the state of this PR, or are there things that need to be reworked first ? Can I help ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add supports for digital potentiometers (DigiPots) that are included on some control boards. I've tested this code on an Ultimachine RAMBo 1.4 board which has an AD5206 DigiPot chip controlled over SPI. This allows for software control of stepper current. By commenting out the
#define HAS_DIGIPOTS, the change should be fully removed from compilation.As a part of this code, a new per-axis setting is included to change the DigiPot value was added as
$14nwherenis one of the axes indexed from 0-2 for x, y, and z. @chamnit suggested in gnea/grbl#696 that I should open a PR with DigiPots support directly onto gnea/grbl-Mega instead of gnea/grbl. We'll probably want to consider a way that we can reserve the$14nsetting so that it doesn't become a different setting on gnea/grbl than it is on gnea/grbl-Mega.