Update README.md #32
gmmorrisAnnotations
48 warnings and 1 notice
|
93 tests found
There are 93 tests, see "Raw output" for the full list of tests.
|
|
this `match` can be collapsed into the outer `match`:
src/selection/sequence.rs#L13
warning: this `match` can be collapsed into the outer `match`
--> src/selection/sequence.rs:13:27
|
13 | Some(json) => match json {
| ___________________________^
14 | | JsonValue::Array(ref array) => array
15 | | .iter()
16 | | .find(|member| match_json_slice(&self.matchers, member, true).is_ok()),
17 | | _ => None,
18 | | },
| |_____________^
|
help: the outer pattern can be modified to include the inner pattern
--> src/selection/sequence.rs:13:18
|
13 | Some(json) => match json {
| ^^^^ replace this binding
14 | JsonValue::Array(ref array) => array
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L96
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:96:50
|
96 | (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
96 - (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
96 + (&JsonValue::Short(ref string_prop), JsonValueMatcher::String(prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L96
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:96:14
|
96 | (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
96 - (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
96 + (JsonValue::Short(string_prop), &JsonValueMatcher::String(ref prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L93
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:93:51
|
93 | (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
93 - (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
93 + (&JsonValue::String(ref string_prop), JsonValueMatcher::String(prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L93
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:93:14
|
93 | (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
93 - (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
93 + (JsonValue::String(string_prop), &JsonValueMatcher::String(ref prop_value)) => {
|
|
|
the following explicit lifetimes could be elided: 'b:
src/selection/prop.rs#L88
warning: the following explicit lifetimes could be elided: 'b
--> src/selection/prop.rs:88:36
|
88 | pub fn prop_value_contains<'a, 'b>(
| ^^
89 | prop: &'a JsonValue,
90 | prop_value_matcher: &'b JsonValueMatcher,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
88 ~ pub fn prop_value_contains<'a>(
89 | prop: &'a JsonValue,
90 ~ prop_value_matcher: &JsonValueMatcher,
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L81
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:81:50
|
81 | (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
81 - (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
81 + (&JsonValue::Short(ref string_prop), JsonValueMatcher::String(prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L81
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:81:14
|
81 | (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
81 - (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
81 + (JsonValue::Short(string_prop), &JsonValueMatcher::String(ref prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L78
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:78:51
|
78 | (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
78 - (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
78 + (&JsonValue::String(ref string_prop), JsonValueMatcher::String(prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L78
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:78:14
|
78 | (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
78 - (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
78 + (JsonValue::String(string_prop), &JsonValueMatcher::String(ref prop_value)) => {
|
|
|
the following explicit lifetimes could be elided: 'b:
src/selection/prop.rs#L73
warning: the following explicit lifetimes could be elided: 'b
--> src/selection/prop.rs:73:42
|
73 | pub fn prop_value_is_suffixed_by<'a, 'b>(
| ^^
74 | prop: &'a JsonValue,
75 | prop_value_matcher: &'b JsonValueMatcher,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
73 ~ pub fn prop_value_is_suffixed_by<'a>(
74 | prop: &'a JsonValue,
75 ~ prop_value_matcher: &JsonValueMatcher,
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L66
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:66:50
|
66 | (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
66 - (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
66 + (&JsonValue::Short(ref string_prop), JsonValueMatcher::String(prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L66
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:66:14
|
66 | (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
66 - (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
66 + (JsonValue::Short(string_prop), &JsonValueMatcher::String(ref prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L63
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:63:51
|
63 | (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
63 - (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
63 + (&JsonValue::String(ref string_prop), JsonValueMatcher::String(prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L63
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:63:14
|
63 | (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
63 - (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
63 + (JsonValue::String(string_prop), &JsonValueMatcher::String(ref prop_value)) => {
|
|
|
the following explicit lifetimes could be elided: 'b:
src/selection/prop.rs#L58
warning: the following explicit lifetimes could be elided: 'b
--> src/selection/prop.rs:58:42
|
58 | pub fn prop_value_is_prefixed_by<'a, 'b>(
| ^^
59 | prop: &'a JsonValue,
60 | prop_value_matcher: &'b JsonValueMatcher,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
58 ~ pub fn prop_value_is_prefixed_by<'a>(
59 | prop: &'a JsonValue,
60 ~ prop_value_matcher: &JsonValueMatcher,
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L47
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:47:50
|
47 | (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
47 - (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
47 + (&JsonValue::Short(ref string_prop), JsonValueMatcher::String(prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L47
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:47:14
|
47 | (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
47 - (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
47 + (JsonValue::Short(string_prop), &JsonValueMatcher::String(ref prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L40
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:40:51
|
40 | (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
40 - (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
40 + (&JsonValue::String(ref string_prop), JsonValueMatcher::String(prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L40
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:40:14
|
40 | (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
40 - (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
40 + (JsonValue::String(string_prop), &JsonValueMatcher::String(ref prop_value)) => {
|
|
|
the following explicit lifetimes could be elided: 'b:
src/selection/prop.rs#L35
warning: the following explicit lifetimes could be elided: 'b
--> src/selection/prop.rs:35:42
|
35 | pub fn prop_value_contains_exact<'a, 'b>(
| ^^
36 | prop: &'a JsonValue,
37 | prop_value_matcher: &'b JsonValueMatcher,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
35 ~ pub fn prop_value_contains_exact<'a>(
36 | prop: &'a JsonValue,
37 ~ prop_value_matcher: &JsonValueMatcher,
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L27
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:27:50
|
27 | (&JsonValue::Boolean(ref bool_prop), &JsonValueMatcher::Boolean(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
27 - (&JsonValue::Boolean(ref bool_prop), &JsonValueMatcher::Boolean(ref prop_value)) => {
27 + (&JsonValue::Boolean(ref bool_prop), JsonValueMatcher::Boolean(prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L27
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:27:14
|
27 | (&JsonValue::Boolean(ref bool_prop), &JsonValueMatcher::Boolean(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
27 - (&JsonValue::Boolean(ref bool_prop), &JsonValueMatcher::Boolean(ref prop_value)) => {
27 + (JsonValue::Boolean(bool_prop), &JsonValueMatcher::Boolean(ref prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L24
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:24:51
|
24 | (&JsonValue::Number(ref number_prop), &JsonValueMatcher::Number(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
24 - (&JsonValue::Number(ref number_prop), &JsonValueMatcher::Number(ref prop_value)) => {
24 + (&JsonValue::Number(ref number_prop), JsonValueMatcher::Number(prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L24
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:24:14
|
24 | (&JsonValue::Number(ref number_prop), &JsonValueMatcher::Number(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
24 - (&JsonValue::Number(ref number_prop), &JsonValueMatcher::Number(ref prop_value)) => {
24 + (JsonValue::Number(number_prop), &JsonValueMatcher::Number(ref prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L21
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:21:50
|
21 | (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
21 - (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
21 + (&JsonValue::Short(ref string_prop), JsonValueMatcher::String(prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L21
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:21:14
|
21 | (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
21 - (&JsonValue::Short(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
21 + (JsonValue::Short(string_prop), &JsonValueMatcher::String(ref prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L18
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:18:51
|
18 | (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
18 - (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
18 + (&JsonValue::String(ref string_prop), JsonValueMatcher::String(prop_value)) => {
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/selection/prop.rs#L18
warning: dereferencing a tuple pattern where every element takes a reference
--> src/selection/prop.rs:18:14
|
18 | (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
= note: `#[warn(clippy::needless_borrowed_reference)]` on by default
help: try removing the `&` and `ref` parts
|
18 - (&JsonValue::String(ref string_prop), &JsonValueMatcher::String(ref prop_value)) => {
18 + (JsonValue::String(string_prop), &JsonValueMatcher::String(ref prop_value)) => {
|
|
|
the following explicit lifetimes could be elided: 'b:
src/selection/prop.rs#L13
warning: the following explicit lifetimes could be elided: 'b
--> src/selection/prop.rs:13:41
|
13 | pub fn prop_value_matches_exact<'a, 'b>(
| ^^
14 | prop: &'a JsonValue,
15 | prop_value_matcher: &'b JsonValueMatcher,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
13 ~ pub fn prop_value_matches_exact<'a>(
14 | prop: &'a JsonValue,
15 ~ prop_value_matcher: &JsonValueMatcher,
|
|
|
this `match` can be collapsed into the outer `match`:
src/selection/identity.rs#L19
warning: this `match` can be collapsed into the outer `match`
--> src/selection/identity.rs:19:30
|
19 | Some(pattern) => match pattern {
| ______________________________^
20 | | "." => Ok((Box::new(Identity {}), None)),
21 | | _ => Err(lens_pattern),
22 | | },
| |_____________^
|
help: the outer pattern can be modified to include the inner pattern
--> src/selection/identity.rs:19:18
|
19 | Some(pattern) => match pattern {
| ^^^^^^^ replace this binding
20 | "." => Ok((Box::new(Identity {}), None)),
| ^^^ with this pattern
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
src/selection/array_member.rs#L28
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> src/selection/array_member.rs:28:19
|
28 | sequence: &'a Vec<JsonValue>,
| ^^^^^^^^^^^^^^^^^^ help: change this to: `&'a [JsonValue]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
|
this `match` can be collapsed into the outer `match`:
src/selection/array_member.rs#L13
warning: this `match` can be collapsed into the outer `match`
--> src/selection/array_member.rs:13:27
|
13 | Some(json) => match json {
| ___________________________^
14 | | JsonValue::Array(ref array) => array.get(self.index),
15 | | _ => None,
16 | | },
| |_____________^
|
help: the outer pattern can be modified to include the inner pattern
--> src/selection/array_member.rs:13:18
|
13 | Some(json) => match json {
| ^^^^ replace this binding
14 | JsonValue::Array(ref array) => array.get(self.index),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
= note: `#[warn(clippy::collapsible_match)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
src/selection/mod.rs#L11
warning: very complex type used. Consider factoring parts into `type` definitions
--> src/selection/mod.rs:11:10
|
11 | ) -> Result<(Box<dyn SelectionLens>, Option<&'a str>), Option<&'a str>>;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
src/input/mod.rs#L94
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> src/input/mod.rs:94:15
|
94 | matchers: &Vec<Vec<Box<dyn SelectionLens>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<Box<dyn SelectionLens>>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
|
very complex type used. Consider factoring parts into `type` definitions:
src/input/mod.rs#L37
warning: very complex type used. Consider factoring parts into `type` definitions
--> src/input/mod.rs:37:16
|
37 | on_result: &dyn Fn(
| ________________^
38 | | (Option<usize>, Option<usize>, Result<String, String>),
39 | | ) -> (Option<usize>, Option<usize>),
| |_______________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
this lifetime isn't used in the function definition:
src/input/mod.rs#L34
warning: this lifetime isn't used in the function definition
--> src/input/mod.rs:34:38
|
34 | pub fn scan_input_for_matching_lines<'a>(
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
= note: `#[warn(clippy::extra_unused_lifetimes)]` on by default
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
src/input/parameter_substitution.rs#L1
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> src/input/parameter_substitution.rs:1:56
|
1 | pub fn apply_substitution(sources: &Vec<&str>, params: &Vec<&str>) -> Vec<String> {
| ^^^^^^^^^^ help: change this to: `&[&str]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
src/input/parameter_substitution.rs#L1
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> src/input/parameter_substitution.rs:1:36
|
1 | pub fn apply_substitution(sources: &Vec<&str>, params: &Vec<&str>) -> Vec<String> {
| ^^^^^^^^^^ help: change this to: `&[&str]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
|
unnecessary hashes around raw string literal:
src/selection/sequence.rs#L29
warning: unnecessary hashes around raw string literal
--> src/selection/sequence.rs:29:28
|
29 | Regex::new(r#"^\[(?P<sequence_matcher>(.)+)\]$"#).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `r"^\[(?P<sequence_matcher>(.)+)\]$"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
|
|
unnecessary hashes around raw string literal:
src/selection/prop.rs#L136
warning: unnecessary hashes around raw string literal
--> src/selection/prop.rs:136:28
|
136 | Regex::new(r#"^\.(?P<prop>([[:word:]])+)(?P<remainder>.+)?$"#).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `r"^\.(?P<prop>([[:word:]])+)(?P<remainder>.+)?$"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
|
|
unnecessary hashes around raw string literal:
src/selection/array_member.rs#L127
warning: unnecessary hashes around raw string literal
--> src/selection/array_member.rs:127:24
|
127 | Regex::new(r#"^\[(?P<index>([[:digit:]])+)\](?P<remainder>.+)?$"#).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `r"^\[(?P<index>([[:digit:]])+)\](?P<remainder>.+)?$"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
= note: `#[warn(clippy::needless_raw_string_hashes)]` on by default
|
|
Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions/cache@v2, codecov/codecov-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|