Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comer até morrer #573

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

InesCardinot
Copy link

This solution refers to which of the apps?

A7 - Identity and Authentication Failures

What did you do to mitigate the vulnerability?

Using JWT for security autenticate

Did you test your changes? What commands did you run?

Yes, i did!

@lgtm-com
Copy link

lgtm-com bot commented Jun 7, 2022

This pull request introduces 8 alerts and fixes 2 when merging b3ce592 into 46a89c9 - view on LGTM.com

new alerts:

  • 3 for Except block handles 'BaseException'
  • 3 for Unused import
  • 2 for Unused local variable

fixed alerts:

  • 1 for Use of a broken or weak cryptographic hashing algorithm on sensitive data
  • 1 for Clear-text storage of sensitive information

now is correct!
@lgtm-com
Copy link

lgtm-com bot commented Jun 8, 2022

This pull request introduces 8 alerts and fixes 2 when merging c84039e into 46a89c9 - view on LGTM.com

new alerts:

  • 3 for Except block handles 'BaseException'
  • 3 for Unused import
  • 2 for Unused local variable

fixed alerts:

  • 1 for Use of a broken or weak cryptographic hashing algorithm on sensitive data
  • 1 for Clear-text storage of sensitive information

@fguisso fguisso self-assigned this Jul 28, 2022
@fguisso fguisso added the refact Code refactoring is needed label Jul 28, 2022
@fguisso
Copy link
Member

fguisso commented Nov 9, 2022

@InesCardinot you have solved one bug but introduced a new one more critical, I had decoded the jwt token and found a PASSWORD 😱 🙀
image
Can you fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refact Code refactoring is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants