Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse as float and then round to int #356

Closed
wants to merge 2 commits into from
Closed

Parse as float and then round to int #356

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32b76d0
Parse as float and then round to int (fixes #355)
daveisfera Feb 6, 2024
3cf8253
Make ruff happy
daveisfera Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion m3u8/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,10 @@ def __init__(self, uri, stream_info, media, base_uri):
if resolution is not None:
resolution = resolution.strip('"')
values = resolution.split("x")
resolution_pair = (int(values[0]), int(values[1]))
resolution_pair = (
int(round(float(values[0]))),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just out of curiosity: is there any packager outputting manifests with decimal resolution?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some example files I was testing with that had 1280.0x720.0 but I'm not sure where they came from. ffmpeg outputs them as integers and I assume that most do as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries, thank you

int(round(float(values[1]))),
)
else:
resolution_pair = None

Expand Down