Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: media_sequence can be zero #258

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mojtaba-arvin
Copy link

The zero media sequence was ignored in the media playlist. (The zero media sequence as default is important for the proper functioning of the players.)

The zero media sequence was ignored in the media playlist. (The zero media sequence as default is important for the proper functioning of the players.)
@davemevans
Copy link
Contributor

This breaks a bunch of the existing tests, and has no accompanying test.

Also, the spec is explicit that if the tag is not in the playlist the value shall be considered to be 0 so it's interesting that this breaks players?

@mojtaba-arvin
Copy link
Author

mojtaba-arvin commented Sep 1, 2021

This breaks a bunch of the existing tests, and has no accompanying test.

Also, the spec is explicit that if the tag is not in the playlist the value shall be considered to be 0 so it's interesting that this breaks players?

 The Seek bar of the player will break and the player will show only ten seconds (the length of a segment) of a one-minute HLS. 
 

 https://github.com/globocom/m3u8/pull/259#issuecomment-910399500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants