dump file with relative path #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
join current working path if the dump path is not absolute.
|
Hi caohong, Thanks for your contribution. I agree that this is an useful feature, but I can't merge it without tests. I would appreciate if you included them on this pull request. Juarez |
|
@caohong are thinking about adding tests? |
|
ok. I'll do it @leandromoreira |
|
@caohong ping? |
|
@leandromoreira , @jbochi If this has not been implemented yet can I implement the same with test cases in a new PR?? |
|
@KuldeepBorkar I think you can but I'd leave the decision to @mauricioabreu :) as he's the most active member rn. |
|
@KuldeepBorkar please, go ahead! |
bbayles
reviewed
Oct 26, 2022
| @@ -181,6 +181,8 @@ def dump(self, filename): | |||
| fileobj.write(self.dumps()) | |||
|
|
|||
| def _create_sub_directories(self, filename): | |||
| if (os.path.isabs(filename) == False): | |||
There was a problem hiding this comment.
Most style guides would prefer:
Suggested change
| if (os.path.isabs(filename) == False): | |
| if not os.path.isabs(filename): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
join current working path if the dump path is not absolute:
m3u8_obj.dump('path1/index.m3u8') instead of m3u8_obj.dump('c:/workingdir/path1/index.m3u8')