Setting local variable for timeOut #517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaveira3
suggested changes
Oct 7, 2020
There was a problem hiding this comment.
Hey, @Lucasdfg07! Thanks for contributing to huskyCI. I have just reviewed your PR but, unfortunately, it does not resolve the problem we described in the issue. You may need to change a few logic in the API as well.
We are having a great discussion in this other PR and I will be very happy to have you there too. Feel free to send more commits on this PR, that we will happily review it again. 🙃
|
Closing this one due to long inactivity. Feel free to reopen it if you are still working on this one, @Lucasdfg07! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation for this PR. Linking the related issue is enough:
Closes #509
Proposed Changes
Changes that this PR will introduce. Are there any breaking changes?
Testing
How can the reviewer assert that the modifications are working as intended? A sequence of commands is just fine: