Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Yarn on root folder only #428

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Run Yarn on root folder only #428

merged 1 commit into from
Nov 22, 2019

Conversation

Krlier
Copy link
Contributor

@Krlier Krlier commented Nov 21, 2019

Recently I came across a repository with more than one Yarn.lock file, one in the root directory of the project and another inside a folder, which caused some issues when running huskyCI.

I believe that in the future it would be nice if huskyCI could find all Yarn.lock files in a project and run an analysis on each and every one of them, which will be addressed in this issue.

For now, my proposal is that huskyCI searches only in the project's root directory for the Yarn.lock file.

Changes:

API:

  • api/config.yaml: Add verification for Yarn.lock in the project's root directory only.

@Krlier Krlier added the refact Code refactoring is needed label Nov 21, 2019
Copy link
Contributor

@rafaveira3 rafaveira3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @Krlier! I got your point! Sounds fair enough to me. This is indeed something we should handle soon! Thanks for this contribution.

@rafaveira3 rafaveira3 merged commit 185b894 into master Nov 22, 2019
@rafaveira3 rafaveira3 deleted the yarn-test-root-only branch November 22, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refact Code refactoring is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants