Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade resty dependency #8

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Upgrade resty dependency #8

merged 3 commits into from
Apr 18, 2024

Conversation

mauricioabreu
Copy link
Member

Update imports
Update logger interface
Fix tests

Update imports
Update logger interface
Fix tests
@KalilCazes
Copy link
Member

Awesome work ❤️ .

@lucasrodcosta
Copy link
Member

@mauricioabreu why change the logger interface?

It wouldn't be enough to keep the NewHTTPClient receiving an io.Writer instead of a Logger?

@mauricioabreu
Copy link
Member Author

@lucasrodcosta I had to change the interface because resty got upgraded, and the new interface is different from v1

One thing I have noticed is that they created a interface for this. So we can replace our custom interface by resty.Logger. What is your opinion?

@mauricioabreu
Copy link
Member Author

I've changed the custom interface by resty.Logger @lucasrodcosta @KalilCazes

@KalilCazes
Copy link
Member

KalilCazes commented Apr 17, 2024

Hey @mauricioabreu .

Could you update the examples section in README? After this PR, a logger struct is needed to initialize NewHTTPClient()

@mauricioabreu
Copy link
Member Author

Good gatch @KalilCazes

Done!

@dneto dneto merged commit c32f558 into globocom:main Apr 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants