chore: update TypeScript to v5 #5271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aberonni
force-pushed
the
aberonni/update-typescript
branch
from
124f777
to
f3b3bd2
Compare
aberonni
force-pushed
the
aberonni/update-typescript
branch
from
f3b3bd2
to
d1f662a
Compare
aberonni
force-pushed
the
aberonni/update-typescript
branch
from
d1f662a
to
248d172
Compare
aberonni
force-pushed
the
aberonni/update-typescript
branch
5 times, most recently
from
24bee4b
to
2483330
Compare
aberonni
force-pushed
the
aberonni/update-typescript
branch
4 times, most recently
from
4b33dce
to
0bfbe0e
Compare
aberonni
force-pushed
the
aberonni/update-typescript
branch
from
0bfbe0e
to
0c86744
Compare
aberonni
force-pushed
the
aberonni/update-typescript
branch
from
0c86744
to
dc19f0b
Compare
elwinschmitz
approved these changes
May 14, 2024
aberonni
added a commit
that referenced
this pull request
May 14, 2024
Merging the PR #5271 seems to have broken the service: https://121-test.scm.azurewebsites.net/api/vfs/LogFiles/2024_05_14_ln0mdlwk00005A_default_docker.log Error along the lines of (while starting the service): ``` npm start 2024-05-14T14:09:10.174478723Z npm info using npm@9.6.4 2024-05-14T14:09:10.174721026Z npm info using node@v18.19.1 2024-05-14T14:09:10.202707456Z 2024-05-14T14:09:10.202758857Z > start 2024-05-14T14:09:10.202765857Z > GLOBAL_121_VERSION=$(test -f "VERSION.txt" && cat VERSION.txt || echo $GLOBAL_121_VERSION) node index.js 2024-05-14T14:09:10.202770557Z 2024-05-14T14:09:10.344822639Z node:internal/modules/cjs/loader:1137 2024-05-14T14:09:10.344871540Z throw err; 2024-05-14T14:09:10.344877840Z ^ 2024-05-14T14:09:10.344882140Z 2024-05-14T14:09:10.344886340Z Error: Cannot find module 'typescript' ``` I think this should fix it. It still remains unclear to me how this happens in test, and we don't catch it sooner. One thing at a time :D
4 tasks
aberonni
added a commit
that referenced
this pull request
May 14, 2024
Merging the PR #5271 seems to have broken the service: https://121-test.scm.azurewebsites.net/api/vfs/LogFiles/2024_05_14_ln0mdlwk00005A_default_docker.log Error along the lines of (while starting the service): ``` npm start 2024-05-14T14:09:10.174478723Z npm info using npm@9.6.4 2024-05-14T14:09:10.174721026Z npm info using node@v18.19.1 2024-05-14T14:09:10.202707456Z 2024-05-14T14:09:10.202758857Z > start 2024-05-14T14:09:10.202765857Z > GLOBAL_121_VERSION=$(test -f "VERSION.txt" && cat VERSION.txt || echo $GLOBAL_121_VERSION) node index.js 2024-05-14T14:09:10.202770557Z 2024-05-14T14:09:10.344822639Z node:internal/modules/cjs/loader:1137 2024-05-14T14:09:10.344871540Z throw err; 2024-05-14T14:09:10.344877840Z ^ 2024-05-14T14:09:10.344882140Z 2024-05-14T14:09:10.344886340Z Error: Cannot find module 'typescript' ``` I think this should fix it. It still remains unclear to me how this happens in test, and we don't catch it sooner. One thing at a time :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#27996
Describe your changes
Updating TS to v5
Checklist before requesting a review