Auto define enum variants as functions #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ie ``` defenum(Color, :color, [:red, :green]) Color.red() => :red ```
…stants This macro in the patch allows for using these enums inside the codebase to represent the same value, instead of needing to redefine them :) Thus: ``` defenum(Status, :status, [:good, :bad, :other]) Status.good() => :good ```
Previously dashes in the atom would break the function definition and make it non-standard Elixir (ie we need valid atoms for function names).
|
Note: this works for some cases but not inside matches and in function heads. To make these work cleanly it needs to be a defmacro and be inlined during compilation. We can hold off on merging this until I can implement that component. The conversion to Macros broke tests, revising :) and will comment when ready for review. |
Make getters macros for pattern matching power
Closed
|
This is ready for review and I'm using it currently as it is in my own projects :). |
|
This would be really helpful to ensure that we're using the right values as constants in the rest of the code-base (i.e. when creating records). Can this be merged? Although it could use some docs. |
|
Are there any plans to merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #87
This patch allows using enum variants as you would use a constant in some languages or a full featured Enum in others.
When variants are defined on an enum, a matching function will be defined for reducing code re-definitions.
It allows for usage as:
Complex atom types are also coerced into idiomatic names:
This PR works for both arity 2 and 3 versions of
defenum. I had tested it for different cases in PG but have not deeply assessed any changes needed for MySQL.You're welcome to tweak the PR for small changes and I'm happy to adjust it myself if something more thorough is needed.
:D