Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: compile test module only on test #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bamorim
Copy link

@bamorim bamorim commented May 12, 2020

Sorry for not even opening an issue, I realized that just opening a PR and explaining would be easier and better for the contribution.

So, when looking at the source code I realize this repository was compiling a module intended only to test it's typespec generation. The problem with that is that then this is shipped to all codebases that use this library.

Another problem is that this adds those modules to the generated ex_docs, which can make people wonder whether or not they are supposed to understand their purpose.

This PR solves this problem by moving that file to a test/support directory and by setting the elixirc_paths to include test/support only on test environments (test and mysql).

@bamorim
Copy link
Author

bamorim commented Jul 22, 2020

Any updates on that?
@gjaldon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant