Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix function names in comment #19609

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

needsure
Copy link

@needsure needsure commented Apr 9, 2024

Description

fix function names in comment

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Signed-off-by: needsure <qinzhipeng@outlook.com>
Copy link

stale bot commented Apr 22, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Apr 22, 2024
@needsure
Copy link
Author

Anything need I to do? If have, Please feel free to tell me.

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Apr 27, 2024
@mustard-mh mustard-mh self-requested a review April 29, 2024 07:27
@mustard-mh
Copy link
Contributor

@needsure Thank you for contributing! As a first-time contributor to Gitpod, would you mind filling out this CLA? It's a one-time thing before your first contribution is merged. Thanks!

@needsure
Copy link
Author

@needsure Thank you for contributing! As a first-time contributor to Gitpod, would you mind filling out this CLA? It's a one-time thing before your first contribution is merged. Thanks!

Of course. Signed

@meysholdt
Copy link
Member

hey @needsure, we've received the signed CLA. Thank you!

@mustard-mh mustard-mh added cla: accepted ✔️ and removed do-not-merge/cla-pending CLA has not been signed labels Apr 29, 2024
@needsure
Copy link
Author

hey @needsure, we've received the signed CLA. Thank you!

图片

I did sign it at least twice. Maybe there is something wrong with the cla service

@mustard-mh
Copy link
Contributor

Hey @needsure would you mind to rebase to main? so that I could build and unblock this PR

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the meta: stale This issue/PR is stale and will be closed soon label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: accepted ✔️ do-not-merge/hold meta: stale This issue/PR is stale and will be closed soon size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants