New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for copy-pasting formatted text to markdown area #7082
Conversation
@randx Looks good |
@jvanbaarsen hope there's no more hidden bugs. |
@randx when I last checked our feature, it cannot copy formatted text, only the image and a plain text. So this fix is for fully supporting all types of text. The reason why our last PR can't copy a formatted text is because we override the printing of text to the text area but the copy paste function is working as is. But for this fix, we changed our approach to just paste any kind of text to the text area when it is not an image. Basically, it can now just copy paste literally any text just like any copy paste function. I hope this clears things out :) |
Fix for copy-pasting formatted text to markdown area
@dosire ok thanks for explaining |
@erbunao I tried this on Windows 8.1 + Chrome 36 via the Gitlab Omnibus 7.1 package. The following did not work:
Am I doing something wrong? |
@sanand0 I don't know, but please open a new issue referencing this one. |
We (@nmcalabroso) fixed the bug for pasting a formatted text to the markdown area. This PR is a fix for #7032. Hoping for the feedbacks.