Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus before show quick commit popup #2927

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

quyenvsp
Copy link

Description

Fix #2906

Because quick commit popup show when click A tag on hovering line popup, vscode do not know what should be focus. So we need hide hovering line popup before show quick commit popup.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@quyenvsp
Copy link
Author

@eamodio Hi, could you review it?

@eamodio
Copy link
Member

eamodio commented Nov 27, 2023

Sorry for the delay. I can't reproduce this issue but it must be a VS Code bug of some kind. Since this "fix" is a hack to workaround that bug and that it is forcing focus to something that may or may not have focus, I don't think GitLens should attempt to fix it. Forcing focus to the active editor group, could have implications to keyboard usage and screen reader support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vscode new version 1.81 hide popup immediately GitLens commit details
2 participants