Closes #302 - Adds Gitlab avatars #2640
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A2-NieR
force-pushed
the
feature/gitlab-avatars
branch
from
0b2abe2
to
90b963b
Compare
Refactor Github avatar function into a generic NoreplyAddress function with Gitlab avatar option Closes gitkraken#302
A2-NieR
force-pushed
the
feature/gitlab-avatars
branch
from
90b963b
to
66b3adc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors the previous Github NoreplyEmail function into a more generic, extendable one while also adding support for Gitlab Avatars.
VSIX package tested successfully, GitLab avatar was displayed in VSCode.
Closes #302
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses