Fix test failure caused by untranslated internal link #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeridth
approved these changes
Apr 12, 2024
Prior to this change the tests would fail with:
Checking 358 external links...
Ran on 300 files!
- _site/pcm/best-practices/index.html
* linking to internal hash #share-ownership-of-your-project that does not exist (line 557)
<a href="../building-community/#share-ownership-of-your-project">share ownership of the project</a>
This fixes the internal anchor to match the translated header text.
ahpook
force-pushed
the
ahpook/fix-pcm-test-failure
branch
from
2e7a7e0
to
0564b92
Compare
|
Couple strange things that we noticed pairing on this w/ @jmeridth 👍
|
Merged
|
Hi guys, I finally managed to resolve the link connections, thanks also to your interventions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the tests would fail with:
Checking 358 external links...
Ran on 300 files!
share ownership of the project
This fixes the internal anchor to match the translated header text.