Repotag jruby compatibility #1347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/master: (39 commits) Release 1.3.3 The command is POSIX, not Posix Release 1.3.2 Spruce up old tests Add empty `a` to support contents with sectnums Add comments to describe these calls No longer true Restore "test" as the default rake task Extconf hack no longer necessary Don't test jdk7 Fallback on open3 if posix-spawn is unavailable. Define CommandImplementation#execute conditional on presence of Posix::Spawn Get html_equal tests running with minitest Updated deprecated .exists? in markup.rb Added the link to Pod::Simple on CPAN. Fix pod output Be more specific with santize dependency Use sanitization filter in tests Render with HTML pipeline Do not test against jruby-head (unstable) ...
Make docs more helpful for end-users
* origin/master: (57 commits) tweaks Call out CSS issues Fix link to linguist Release 1.3.3 The command is POSIX, not Posix Release 1.3.2 Spruce up old tests Add empty `a` to support contents with sectnums Add comments to describe these calls No longer true Restore "test" as the default rake task point to other places before creating issues Extconf hack no longer necessary Don't test jdk7 Fallback on open3 if posix-spawn is unavailable. Define CommandImplementation#execute conditional on presence of Posix::Spawn Get html_equal tests running with minitest Updated deprecated .exists? in markup.rb Added the link to Pod::Simple on CPAN. Fix pod output ... Conflicts: lib/github/markup.rb test/markup_test.rb
Add #name to renderers
Link to primer for styling issues
Add Ruby syntax highlighting
Closes github#497.
Fix a couple of RST issues
upgrade to Asciidoctor 1.5.2
This addresses issue github#514. Previous behavior was to silently ignore unknown directives and comments, which made .rst documents that utilized rst extensions appear to be incomplete. This fix allows all the information to be displayed, and further allows comments to be placed to indicate that the github rst viewer is not the preferred viewer for the document. This patch will not alter the appearance of any document that is specifically coded for display at github which doesn't use restucturedText comments. Additional possible enhancements include figuring out how to gray out this text, and/or to support a special github directive at the start of the text file that controls whether this new behavior is enabled.
Also add test file to show new operation.
My docutils configuration must be slightly different than github's.
pod62html tweaks
add markup options
- upgrade to Asciidoctor 2.0.x (starting with 2.0.5) - switch to fuzzy version match for asciidoctor gem - disable sectanchors (since they get removed by the sanitizer anyway) - use formal xref macro for interdocument xref in test - add test for toggling the document title using showtitle/!showtitle - add test to verify toc is generated at top of document when toc attribute is set
…-asciidoctor-2 resolves github#1258 upgrade to Asciidoctor 2.0.x
(Vulnerability alert doesn't exactly apply as it's never used in actual execution, but that's okay.)
…-to-options Add extensions to commonmarker options
…r-options Improve commonmarker test case
It is recommended to use the squiggly HEREDOC syntax (https://infinum.co/the-capsized-eight/multiline-strings-ruby-2-3-0-the-squiggly-heredoc) for multiline strings.
Co-Authored-By: Ashe Connor <kivikakk@github.com>
Use squiggly HEREDOC syntax
Check whether filename is set when rendering asciidoc. Resolves github#1289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.