This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Refactoring RepositoryForm Validators #2395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcansdale
reviewed
Jun 28, 2019
| await SafeRepositoryNameWarningValidator.ResetAsync(); | ||
| RepositoryName = name; | ||
| }); | ||
| // this.WhenAny(x => x.SelectedConnection, x => x.SelectedAccount, |
There was a problem hiding this comment.
We should delete these comments!
jcansdale
reviewed
Jun 28, 2019
jcansdale
reviewed
Jun 28, 2019
| @@ -25,8 +25,8 @@ public interface IRepositoryForm : IViewModel | |||
| /// dashes. | |||
| /// </summary> | |||
| string SafeRepositoryName { get; } | |||
| ReactivePropertyValidator<string> RepositoryNameValidator { get; } | |||
| ReactivePropertyValidator<string> SafeRepositoryNameWarningValidator { get; } | |||
| ReactivePropertyValidator<(string repositoryName, IConnection connection, IAccount account)> RepositoryNameValidator { get; } | |||
There was a problem hiding this comment.
Looking at the code, I can't see where we're using the connection or account for validation. I wonder if once upon a time we were checking for an existing repository with the same name as part of the validation? It looks like this check is now done and the error surfaced when the user attempts to create the repository.
I think we might be able to simplify this to use just the repositoryName. I'm wondering if the buggy code was actually completely obsolete. ;-)
jcansdale
suggested changes
Jun 28, 2019
There was a problem hiding this comment.
I'm wondering if we could simply remove the buggy code?
See comment:
#2395 (review)
RobbyLena
approved these changes
Jan 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.