New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t9803-git-p4-shell-metachars.sh: update to use test_path_* functions #1691
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: sanchit1053 <sanchit1053@gmail.com>
There are issues in commit 1eeb082: |
1 similar comment
There are issues in commit 1eeb082: |
There are issues in commit 38caf97: |
There are issues in commit 1eeb082: |
There are issues in commit 38caf97: |
80741dd
to
b8d0620
Compare
/submit |
Submitted as pull.1691.git.git.1711049963.gitgitgadget@gmail.com To fetch this version into
To fetch this version to local tag
|
On the Git mailing list, Eric Sunshine wrote (reply to this), regarding b8d0620: On Thu, Mar 21, 2024 at 3:39 PM Sanchit Jindal via GitGitGadget
<gitgitgadget@gmail.com> wrote:
> From: Sanchit Jindal <sanchit1053@gmail.com>
>
> replacing `test -e` with test_path_exists,
> `test ! -e` with test_path_is_missing
> `test -f` with test_path_is_file
> These helper functions will run the `test` command with the
> corresponding flags and will echo a message if the assert fails.
> This will provide better debugging logs for test, instead of the
> previous method which provided no message
>
> Signed-off-by: Sanchit Jindal <sanchit1053@gmail.com>
When rerolling a series to address reviewer comments, you will want
the fixes applied directly to the patches about which the reviewers
commented. The way to do this is to use `git rebase -i` to adjust the
patches as needed. In the case of this simple series, you just want to
"squash" patches [1/2] and [2/2] into a single patch using the `git
rebase -i` "squash" command, and adjust the commit message of the
squashed patch appropriately. Finally, to resubmit it via
GitGitGadget, force-push the revised series to GitGitGadget (using
`git push --force <whatever> <whatever>`), and tell GitGitGadget to
"/submit".
Regarding the commit message, first explain the problem the patch is
solving, and then explain how the patch solves it. Thus, start by
explaining that `test` doesn't provide any diagnostic information when
it fails, which isn't helpful to test authors. Then explain that the
patch replaces `test` with the test_path_* functions which do provide
useful diagnostic information.
The From: and Signed-off-by: lines look good in this reroll. |
User |
b8d0620
to
58f07ff
Compare
There are issues in commit 58f07ff: |
Using the `test` function directly does not provide any diagnostic information to the user, in case of a failure. This patch replace the `test` function with the helper functions defined that will call the corresponding test function and log an error message if the assert fails Making the replacements - `test -e` -> test_path_exists, - `test ! -e` -> test_path_is_missing - `test -f` -> test_path_is_file Signed-off-by: Sanchit Jindal <sanchit1053@gmail.com>
58f07ff
to
e25b5f9
Compare
/submit |
Submitted as pull.1691.v2.git.git.1711052946.gitgitgadget@gmail.com To fetch this version into
To fetch this version to local tag
|
On the Git mailing list, Sanchit Jindal wrote (reply to this), regarding b8d0620 (outdated): On Fri, 22 Mar 2024 at 01:22, Eric Sunshine <sunshine@sunshineco.com> wrote:
>
> On Thu, Mar 21, 2024 at 3:39 PM Sanchit Jindal via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> > From: Sanchit Jindal <sanchit1053@gmail.com>
> >
> > replacing `test -e` with test_path_exists,
> > `test ! -e` with test_path_is_missing
> > `test -f` with test_path_is_file
> > These helper functions will run the `test` command with the
> > corresponding flags and will echo a message if the assert fails.
> > This will provide better debugging logs for test, instead of the
> > previous method which provided no message
> >
> > Signed-off-by: Sanchit Jindal <sanchit1053@gmail.com>
>
> When rerolling a series to address reviewer comments, you will want
> the fixes applied directly to the patches about which the reviewers
> commented. The way to do this is to use `git rebase -i` to adjust the
> patches as needed. In the case of this simple series, you just want to
> "squash" patches [1/2] and [2/2] into a single patch using the `git
> rebase -i` "squash" command, and adjust the commit message of the
> squashed patch appropriately. Finally, to resubmit it via
> GitGitGadget, force-push the revised series to GitGitGadget (using
> `git push --force <whatever> <whatever>`), and tell GitGitGadget to
> "/submit".
>
> Regarding the commit message, first explain the problem the patch is
> solving, and then explain how the patch solves it. Thus, start by
> explaining that `test` doesn't provide any diagnostic information when
> it fails, which isn't helpful to test authors. Then explain that the
> patch replaces `test` with the test_path_* functions which do provide
> useful diagnostic information.
>
> The From: and Signed-off-by: lines look good in this reroll.
Thank You for the review
I renamed the branch using github as it had a typo which made the
earlier patch to be erased.I am extremely sorry about this.
I have created another patch with a more descriptive commit message,
and after squashing it with the earlier commit. I hope it is satisfactory
I wanted to ask, Is it possible to send the patches created using
`git format-patch` manually using gmail, Or the default headers
applied by `send-email` required.
Regards,
Sanchit Jindal |
On the Git mailing list, Junio C Hamano wrote (reply to this), regarding b8d0620 (outdated): Sanchit Jindal <sanchit1053@gmail.com> writes:
> I have created another patch with a more descriptive commit message,
> and after squashing it with the earlier commit. I hope it is satisfactory
Hopefully. What GGG sent with v2 label still was a 2-patch series,
whose [2/2] patch was an empty patch, though.
> I wanted to ask, Is it possible to send the patches created using
> `git format-patch` manually using gmail, Or the default headers
> applied by `send-email` required.
I do not know where you are using gmail from (I know that Android
version has no way to send text-only e-mail for example), but when
cutting and pasting the output from format-patch, you should make
sure
* Remove "From <commit object name> Mon Sep 17 00:00:00 2001"
marker line that signals the beginning of each patch message. It
is a mistake to leave this line in the body of your message.
* Remove "Date: " header. Do not leave this line in the body of
your message.
* Remove "Subject: " header and move its contents to your MUA's
Subject entry field.
* Remove "From: " header, and arrange that your MUA puts the same
"Sanchit Jindal <sanchit1053@gmail.com> on the From header. If
your MUA is not cooperating, you can leave that line in the body
of the message
* Your cut&paste does not corrupt whitespaces, like squashing two
consecutive spaces into one, removing the leading whitespaces,
turning a tab into a run of spaces, folding a line at a
whitespace in the middle of the message, etc.
* Your MUA does not turn your text message into HTML gunk.
As long as you do the above carefully, you should be OK. "git
format-patch --help" has a section on MUA specific hints, which also
might be helpful.
Thanks. |
Correct Typo in Branch name
cc: Eric Sunshine sunshine@sunshineco.com