New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update FreeBSD image to currently supported 13.2 release #1634
base: master
Are you sure you want to change the base?
Conversation
Welcome to GitGitGadgetHi @emaste, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests. Please make sure that your Pull Request has a good description, as it will be used as cover letter. You can CC potential reviewers by adding a footer to the PR description with the following syntax:
Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:
It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code. Contributing the patchesBefore you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form Both the person who commented An alternative is the channel
Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment If you want to see what email(s) would be sent for a After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail). If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the curl -g --user "<EMailAddress>:<Password>" \
--url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):
To send a new iteration, just add another PR comment with the contents: Need help?New contributors who want advice are encouraged to join git-mentoring@googlegroups.com, where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join. You may also be able to find help in real time in the developer IRC channel, |
/allow |
User emaste is now allowed to use GitGitGadget. WARNING: emaste has no public email address set on GitHub; |
Hi @emaste, did you wish to send this to the mailing list ? it would be nice since it would keep the FreeBSD CI builds running correctly :) |
an identical change has been submitted by @carenas here (thanks!): https://lore.kernel.org/git/20240131191325.33228-1-carenas@gmail.com/ |
FreeBSD 12.x is now EOL. Signed-off-by: Ed Maste <emaste@FreeBSD.org>
Carlos's similar patch is already on |
$ git range-diff 81fffb66d3f702c269a5aee6e403c3ec62fc0277^! ba3248721914d6918fb75597d415269c714683b7^!
@emaste Your patch seems to be a bit more specific, whereas @carenas' patch seems a bit more future-proof by avoiding to hard-code the FreeBSD version. Are you good with that? |
sadly the image name encodes the version number so the plan was to upgrade the image to 13.3 once that version gets released and which would at least ensure the version used woud have support for a little longer. @emaste: ammending this PR to do that would be IMHO ideal |
FreeBSD 12.x is now EOL.