Adds --remote-root option support for '=<param>' suffix. #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other flags taking arguments support this currently.
|
I hope the blank lines cleanup is welcome (my editor audo-does this on save) |
LukasFritzeDev
requested changes
May 9, 2020
| REMOTE_ROOT=$(expr "z$1" : 'z-[^=]*=\(.*\)') | ||
| ;; | ||
| 1,*) | ||
| print_error_and_die "Too few arguments for option --key." "$ERROR_MISSING_ARGUMENTS" |
There was a problem hiding this comment.
I think there is a copy & past error. It should be option --remote-root
| REMOTE_ROOT="$2" | ||
| shift | ||
| else | ||
| print_error_and_die "Too few arguments for option --key." "$ERROR_MISSING_ARGUMENTS" |
There was a problem hiding this comment.
Same here 😆
I think there is a copy & past error. It should be option --remote-root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other flags taking arguments support this currently. It means using:
--remote-root=my_remote_foldershould work with this change.