Replacing GISMO_UNUSED with EIGEN_UNUSED_VARIABLE in gsEigen #703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
FIXED: I have replaced
GISMO_UNUSED
withEIGEN_UNUSED_VARIABLE
in external/gsEigen.TL;DR
With the
GISMO_UNUSED
I cannot use solution 5 from #566 anymore.Longer explanation
I am compiling an application that depends both G+Smo and another library that also uses Eigen. In order to prevent issues from having two copies of Eigen, the following solution has worked great in the past:
make install
,-I
-ing the content of the gsEigen that G+Smo made in step 1,Step 2. currently fails due to
GISMO_UNUSED
not being defined. After replacing it withEIGEN_UNUSED_VARIABLE
, step 2 works without problems. In my view, the content of the external/gsEigen should generally not depend on anything G+Smo specific.The checklist
you'd like us to include them? Yes, see above.