Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing GISMO_UNUSED with EIGEN_UNUSED_VARIABLE in gsEigen #703

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

dominik-mokris-mtu
Copy link
Contributor

Changes

FIXED: I have replaced GISMO_UNUSED with EIGEN_UNUSED_VARIABLE in external/gsEigen.

TL;DR

With the GISMO_UNUSED I cannot use solution 5 from #566 anymore.

Longer explanation

I am compiling an application that depends both G+Smo and another library that also uses Eigen. In order to prevent issues from having two copies of Eigen, the following solution has worked great in the past:

  1. install G+Smo with make install,
  2. compile the other library -I-ing the content of the gsEigen that G+Smo made in step 1,
  3. compile my application linking to the results of steps 1 and 2.

Step 2. currently fails due to GISMO_UNUSED not being defined. After replacing it with EIGEN_UNUSED_VARIABLE, step 2 works without problems. In my view, the content of the external/gsEigen should generally not depend on anything G+Smo specific.

The checklist

  • Have you added an explanation of what your changes do and why
    you'd like us to include them? Yes, see above.
  • Have you documented any new codes using Doxygen comments? No, I don't think it is necessary.
  • Have you written new tests or examples for your changes? No, I don't think it is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant