This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
Proposal implementation using the CodagRestFabricationBundle #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -244,7 +247,8 @@ public function putNotesAction(Request $request, $id) | |||
| * @ApiDoc( | |||
| * resource = true, | |||
| * statusCodes={ | |||
| * 204="Returned when successful" | |||
| * 204="Returned when successful", | |||
| * 404 = "Returned when the note is not found" | |||
There was a problem hiding this comment.
a 404 shouldnt happen here as PUT should create the note in the given location
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shall be the proposal using the the RestFabricationBundle as mentioned here: https://groups.google.com/forum/#!topic/resting-with-symfony/UNaK4fFzVF0
In this sample project we can unfortunately just profit from a subset of the provided features:
Due to the lack of the entity manager usage, unfortunately the DefaultDomainManager cannot be presented. In combination with multiple entities this would be one of the key benefits of this bundle. Even though I guess the current implementation will represent some parts of this particular designed workflow.