Check whether the return value from RateLimit.from_http() is None

[Kjeld-P]

In handling error-responses from the server the code checks if it's possible to create a rate limit object from the headers through RateLimit.from_http(headers). This function returns an object if rate limit info was found, and None otherwise.

The next line of code wants to check if this value was not none, but does not do so explicitly: if rate_limit. This causes python to evaluate it as a boolean and call RateLimit.__bool__. This will only return True if self.remaining > 0, which would not be the case if the rate-limit was indeed exceeded.

The proposed fix simply explicitly checks if the returned RateLimit object is not None.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f8cec4) 100.00% compared to head (bb6a1ed) 100.00%.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #207   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          471       471           
  Branches        87        87           
=========================================
  Hits           471       471           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brettcannon]

You're right about the bug! Slight code tweak to your PR and it's failing linting.

[Kjeld-P]

@brettcannon Thanks, added the suggestion!

[brettcannon]

I just realized there isn't a test for this. 😅 Could you add one?

[Mariatta]

We also need the changelog entry for this bug fix.