Added xfs support, parameter mount_options #60

dsvetl · 2018-02-19T21:24:27Z

Hello,

I added two small feature:

Added support for xfs filesystem.
Added options for pass mount options (e.g. compress=zstd).

I am using Shell Parameter Expansion to resolve problem in #59.

${parameter:+word}
If parameter is null or unset, nothing is substituted,
otherwise the expansion of word is substituted.

gh2o · 2018-04-29T20:50:20Z

Looks good. Can you update components/base-install.sh, then re-run tools/build_self_contained_install.sh to rebuild install.sh? Thanks!

z3ntu · 2018-04-29T21:40:44Z

install.sh

@@ -110,6 +113,7 @@ flag_variables=(
 	target_disklabel
 	target_filesystem
 	mkfs_options
+        mount_options


intendation seems different here

z3ntu · 2018-04-29T21:42:03Z

README.md

@@ -54,7 +57,7 @@ This script supports several flags, all of which are optional.
  as used by EFI). The alternative is `dos` (traditional MBR).
 * `--target_filesystem`  
  The filesystem on which the Arch Linux installation should be installed.
-  Defaults to `ext4`. The alternative is `btrfs`.
+  Defaults to `ext4`. The alternative is `btrfs` and `xfs`.


btrfs or xfs? And I think "The alternative" isn't suitable for multiple 'alternatives'

dsvetl added 2 commits February 20, 2018 00:13

added xfs filesystem support

4621415

added parameter mount_options

6003ada

z3ntu reviewed Apr 29, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added xfs support, parameter mount_options #60

Added xfs support, parameter mount_options #60

dsvetl commented Feb 19, 2018

gh2o commented Apr 29, 2018

z3ntu Apr 29, 2018

z3ntu Apr 29, 2018

Added xfs support, parameter mount_options #60

Are you sure you want to change the base?

Added xfs support, parameter mount_options #60

Conversation

dsvetl commented Feb 19, 2018

gh2o commented Apr 29, 2018

z3ntu Apr 29, 2018

Choose a reason for hiding this comment

z3ntu Apr 29, 2018

Choose a reason for hiding this comment