Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTMLImageElement/ImageData as external source for copying images #5668

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

valaphee
Copy link
Contributor

@valaphee valaphee commented May 5, 2024

Connections
Solves #4236
Depends on grovesNL/glow#291

Description
This adds the missing external sources for HTMLImageElement and ImageData which are useful for removing the need to ship an image decoder with an wasm application.

Testing
TODO: We should add a texture example, which on wasm loads the texture via external image source.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@valaphee
Copy link
Contributor Author

valaphee commented May 5, 2024

Now just VideoFrame is missing, but this also seems to be experimental

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant