[hal] Document resource destruction methods, and a few other things. #5627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
force-pushed
the
hal-document-destroy-methods
branch
2 times, most recently
from
ca58eee
to
daa3653
Compare
ErichDonGubler
approved these changes
May 3, 2024
, minus nits I'm trusting to be handled.
jimblandy
force-pushed
the
hal-document-destroy-methods
branch
from
f3ac026
to
bf6cce0
Compare
|
@ErichDonGubler I've accepted most of your suggestions, but had some questions. |
ErichDonGubler
approved these changes
May 16, 2024
|
that didn't go well |
jimblandy
force-pushed
the
hal-document-destroy-methods
branch
from
e58e2d7
to
7080697
Compare
|
Okay, I think I've undone the damage. |
jimblandy
force-pushed
the
hal-document-destroy-methods
branch
from
7080697
to
5ce674b
Compare
Document some more safety expectations for - resource destruction methods - `CommandEncoder` methods - `Queue::submit` Document `Fence` creation a bit. Document the `Queue` trait a bit. Document `vulkan` shader module handling a bit.
jimblandy
force-pushed
the
hal-document-destroy-methods
branch
from
5ce674b
to
c92968e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document some more safety expectations for
CommandEncodermethodsQueue::submitDocument
Fencecreation a bit.Document the
Queuetrait a bit.