Remove lifetime dependency of ComputePass to its parent command encoder
#5620
+1,481
−498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectly on recording TODO: * bind groups don't work because the Binder gets an id only * wgpu level error handling is missing
…eeds to lock bind_group storage
… DynComputePass on wgpu side
…hod of compute/render pass instead of encoder
…removing compile time dependency to it
This was referenced Apr 28, 2024
Wumpf
force-pushed
the
lifetime-free-computepass2
branch
from
ed88c1f
to
70c925d
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
RenderPassmake it difficult to use. #1453Part of a series towards lifetime removal on compute passes:
wgpu::ComputePass) #5432wgpu::ComputePassmethods #5570ComputePassto its parent command encoder #5620Description
ComputePasshad a static lifetime dependency to its parent encoder. This PR removes this (ComputePass<'a>->ComputePass) by havingComputePassown an Arc to its parent encoder. A side-effect of this is thatComputePasscreation can now fail in theory (if an invalid id is passed or commandbuffer allocation fails for some reason).Another wide reaching side effect is that command encoders can now be in a
Lockedstate. (via WebGPU spec) any operation on a locked command encoder fails and makes the encoder invalid.The last remaining lifetime dependency to resolve on
ComputePassafter this PR is inComputePassTimestampWrites<'a>: We currently don't bump the reference count on the referencedQuerySet. This is in fact more of a pre-existing bug since destroying a QuerySet after recording it in a ComputePass and before closing the pass already causes issues!Testing
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.Add change toCHANGELOG.md. See simple instructions inside file.