New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JPEG XL support to image processing. #2488
base: next
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some tests? They are in imageproc/tests
Absolutely - what do you think I should test? For now I just added a PNG to JXL test. |
Maybe a JXL output with a JXL input? The CI failures look legit though |
Ah, JXL reading is not supported :D do you think I should add that? As for the CI... I believe I need to add the system dependency, but I have no idea how to configure that - any pointers? |
It depends whether it can be added or not. If so then yes
It looks like there is a |
Did both of those. Also, my pr to jpegxl-rs was accepted and a release should be coming soon, so perhaps waiting a day or two and switching to the next version of jpegxl-rs would be the ideal solution. In case you are wondering why I did not use the "image" feature of jpegxl-rs: it depends on a different version of "image", and trying to upgrade the dependency for zola to 0.25 produced some dependency incompatibility errors. |
I will update to 0.25 soonish, but I haven't looked at the image feature of jpeg-xl-rs. If that's better, I can update it now and you rebase your PR on it? |
If you can do that, it'd be great! Looks like there are some build issues with jpegxl-rs, so it'll be a while before this PR can be merged anyway :-) |
|
Thanks! I updated the PR accordingly (also squashing the commits, since I was going to rebase anyway...) |
Can you rebase? CI is fixed minus windows which i'll look at later |
dd43221
to
3eda012
Compare
As discussed in getzola#2421.
I made a mess with rebasing, but it should be done now :-) |
CI failures seem legit |
Yep, they are, I am hoping they will be resolved on the jpegxl_rs side (inflation/jpegxl-rs#50) and jxl side (inflation/jpegxl-rs#51) as soon as I can get to it :-) |
As discussed in #2421.
Sanity check:
Code changes
next
branch?If the change is a new feature or adding to/changing an existing one: