Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JPEG XL support to image processing. #2488

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

veluca93
Copy link

@veluca93 veluca93 commented May 1, 2024

As discussed in #2421.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

  • Are you doing the PR on the next branch?

If the change is a new feature or adding to/changing an existing one:

  • Have you created/updated the relevant documentation page(s)?

Copy link
Collaborator

@Keats Keats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests? They are in imageproc/tests

components/imageproc/src/processor.rs Outdated Show resolved Hide resolved
@veluca93
Copy link
Author

veluca93 commented May 4, 2024

Can you add some tests? They are in imageproc/tests

Absolutely - what do you think I should test? For now I just added a PNG to JXL test.

@Keats
Copy link
Collaborator

Keats commented May 4, 2024

Maybe a JXL output with a JXL input? The CI failures look legit though

@veluca93
Copy link
Author

veluca93 commented May 4, 2024

Maybe a JXL output with a JXL input? The CI failures look legit though

Ah, JXL reading is not supported :D do you think I should add that?

As for the CI... I believe I need to add the system dependency, but I have no idea how to configure that - any pointers?

@Keats
Copy link
Collaborator

Keats commented May 4, 2024

Ah, JXL reading is not supported :D do you think I should add that?

It depends whether it can be added or not. If so then yes

As for the CI... I believe I need to add the system dependency, but I have no idea how to configure that - any pointers?

It looks like there is a vendored feature for statically linking it

@veluca93
Copy link
Author

veluca93 commented May 4, 2024

Ah, JXL reading is not supported :D do you think I should add that?

It depends whether it can be added or not. If so then yes

As for the CI... I believe I need to add the system dependency, but I have no idea how to configure that - any pointers?

It looks like there is a vendored feature for statically linking it

Did both of those. Also, my pr to jpegxl-rs was accepted and a release should be coming soon, so perhaps waiting a day or two and switching to the next version of jpegxl-rs would be the ideal solution.

In case you are wondering why I did not use the "image" feature of jpegxl-rs: it depends on a different version of "image", and trying to upgrade the dependency for zola to 0.25 produced some dependency incompatibility errors.

@Keats
Copy link
Collaborator

Keats commented May 4, 2024

it depends on a different version of "image", and trying to upgrade the dependency for zola to 0.25 produced some dependency incompatibility errors.

I will update to 0.25 soonish, but I haven't looked at the image feature of jpeg-xl-rs. If that's better, I can update it now and you rebase your PR on it?

@veluca93
Copy link
Author

veluca93 commented May 4, 2024

it depends on a different version of "image", and trying to upgrade the dependency for zola to 0.25 produced some dependency incompatibility errors.

I will update to 0.25 soonish, but I haven't looked at the image feature of jpeg-xl-rs. If that's better, I can update it now and you rebase your PR on it?

If you can do that, it'd be great!

Looks like there are some build issues with jpegxl-rs, so it'll be a while before this PR can be merged anyway :-)

@Keats
Copy link
Collaborator

Keats commented May 9, 2024

next has been updated with image 0.25

@veluca93
Copy link
Author

veluca93 commented May 9, 2024

Thanks! I updated the PR accordingly (also squashing the commits, since I was going to rebase anyway...)

@Keats
Copy link
Collaborator

Keats commented May 14, 2024

Can you rebase? CI is fixed minus windows which i'll look at later

@veluca93 veluca93 force-pushed the jxl branch 2 times, most recently from dd43221 to 3eda012 Compare May 14, 2024 18:00
@veluca93
Copy link
Author

Can you rebase? CI is fixed minus windows which i'll look at later

I made a mess with rebasing, but it should be done now :-)

components/imageproc/src/format.rs Outdated Show resolved Hide resolved
@Keats
Copy link
Collaborator

Keats commented May 16, 2024

CI failures seem legit

@veluca93
Copy link
Author

CI failures seem legit

Yep, they are, I am hoping they will be resolved on the jpegxl_rs side (inflation/jpegxl-rs#50) and jxl side (inflation/jpegxl-rs#51) as soon as I can get to it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants