feat(performance): Adds error rate to queues module #70883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
gggritso
approved these changes
May 14, 2024
| @@ -41,6 +41,7 @@ function DestinationSummaryPage() { | |||
| const destination = decodeScalar(query.destination); | |||
|
|
|||
| const {data} = useQueuesMetricsQuery({destination}); | |||
| const errorRate = 1 - (data[0]?.['trace_status_rate(ok)'] ?? 0); | |||
There was a problem hiding this comment.
😅 there's no trace_status_rate(error) for you?
There was a problem hiding this comment.
Unfortunately the trace context status has a bunch of different error states:
https://develop.sentry.dev/sdk/event-payloads/contexts/#trace-context
ie cancelled, unknown, invalid_argument are all possible values and are all considered errors.
Right now trace_status_rate just applies a filter for the provided status
I can update this in discover as a follow up!
There was a problem hiding this comment.
Makes sense! Definitely worth it to define a helper for this in Discover regardless, if possible
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Queues module to now fully display error rate in the:
Also includes a minor fix to producer/consumer sample panel readouts not showing accurate span counts.