ref(crons): Tighten check_{missed,timeout} queries #70873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #70873 +/- ##
=========================================
Coverage ? 80.00%
=========================================
Files ? 6506
Lines ? 290896
Branches ? 50139
=========================================
Hits ? 232739
Misses ? 57726
Partials ? 431
|
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-tighten-check-missed-timeout-queries
branch
from
3288325
to
9acafa4
Compare
We don't need to select everything. We can potentially improve query performance here by allowing a Index Only scan [0], where the data comes straight from the index [0]: https://pganalyze.com/docs/explain/scan-nodes/index-only-scan
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-tighten-check-missed-timeout-queries
branch
from
9acafa4
to
be6fb3b
Compare
JoshFerge
approved these changes
May 15, 2024
evanpurkhiser
deleted the
evanpurkhiser/ref-crons-tighten-check-missed-timeout-queries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to select everything. We can potentially improve query
performance here by allowing a Index Only scan 1, where the data comes
straight from the index
Footnotes
https://pganalyze.com/docs/explain/scan-nodes/index-only-scan ↩