feat(new-trace): add cache metrics to transaction trace details #70868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
DominikB2014
commented
May 14, 2024
| @@ -49,7 +49,7 @@ export const DataTitles: Record<DataKey, string> = { | |||
| 'avg(cache.item_size)': t('Avg Value Size'), | |||
| unsuccessfulHTTPCodes: t('Response Codes (3XX, 4XX, 5XX)'), | |||
| httpCodeBreakdown: t('Response Code Breakdown'), | |||
| cacheMissRate: t('Miss Rate'), | |||
| 'cache_miss_rate()': t('Miss Rate'), | |||
There was a problem hiding this comment.
Threw in an extra refactor here, sorry about that
Bundle ReportChanges will increase total bundle size by 7.96kB ⬆️
|
JonasBa
reviewed
May 16, 2024
JonasBa
reviewed
May 16, 2024
static/app/views/performance/newTraceDetails/traceDrawer/details/transaction/index.tsx
Outdated
Show resolved
Hide resolved
JonasBa
reviewed
May 16, 2024
static/app/views/performance/newTraceDetails/traceDrawer/details/transaction/index.tsx
Outdated
Show resolved
Hide resolved
|
@JonasBa I've addressed you're comments about allowing cache metrics to load independently and mapping all the cache metrics instead of the first element. Lmk what u think! |
JonasBa
approved these changes
May 24, 2024
|
@DominikB2014 I'm really sorry about this, I must have missed the gh notification. Please feel free to ping me sooner next time, I try to reply to all notifications in less than a day |
volokluev
pushed a commit
that referenced
this pull request
May 28, 2024
Adds cache metrics section to a transaction node, if the transaction has cache metrics <img width="393" alt="image" src="https://github.com/getsentry/sentry/assets/44422760/d1bdf928-b665-4446-ba8e-e188a62462f2">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cache metrics section to a transaction node, if the transaction has cache metrics
