Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(new-trace): Displaying emmitted metrics with new ui. #70864

Merged
merged 2 commits into from
May 16, 2024
Merged

feat(new-trace): Displaying emmitted metrics with new ui. #70864

merged 2 commits into from
May 16, 2024
+106 −355

Conversation

Abdkhan14
Copy link
Contributor

Before:
Screenshot 2024-05-14 at 12 23 22 PM

After:
Screenshot 2024-05-14 at 12 23 00 PM

@Abdkhan14 Abdkhan14 requested review from JonasBa and a team May 14, 2024 16:24
@Abdkhan14 Abdkhan14 requested a review from a team as a code owner May 14, 2024 16:24
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 14, 2024
@Abdkhan14 Abdkhan14 merged commit 3d98e12 into master May 16, 2024
40 of 41 checks passed
@Abdkhan14 Abdkhan14 deleted the abdk/trace-emitted-metrics-formatting branch May 16, 2024 14:13
cmanallen pushed a commit that referenced this pull request May 21, 2024
@Abdkhan14 @cmanallen
feat(new-trace): Displaying emmitted metrics with new ui. (#70864)
b79184a 
Before:
<img width="1510" alt="Screenshot 2024-05-14 at 12 23 22 PM"
src="https://github.com/getsentry/sentry/assets/60121741/eefe8b7b-b06e-4f5b-9ce4-495b0184becb">

After: 
<img width="1508" alt="Screenshot 2024-05-14 at 12 23 00 PM"
src="https://github.com/getsentry/sentry/assets/60121741/8031d795-9d64-4851-a34e-cb5bb1d96061">

---------

Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejminar matejminar matejminar approved these changes

@JonasBa JonasBa JonasBa approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Abdkhan14 @matejminar @JonasBa