Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-builder): Ensure that search bar only has a single tab stop #70863

Merged
merged 1 commit into from
May 14, 2024

Conversation

malwilley
Copy link
Member

Pressing tab from the element before the search bar should focus the last input inside the search bar. While focus is within the search bar, tabbing or shift tabbing should exit the search bar, not focus any of the other focusable elements within it.

  • Adds tabIndex="-1" to all the focusable elements
  • Ensures that the selectionManager focus state gets updated correctly when arrowing around the search bar. This ensures that when the search bar receives focus again, the correct element is focused.
  • Adds an onFocus handler to the top level grid element that will set the focus to the last element if the user hasn't interacted with the search bar yet.

@malwilley malwilley requested a review from a team May 14, 2024 16:11
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 14, 2024
Copy link

codecov bot commented May 14, 2024

Bundle Report

Changes will increase total bundle size by 7.74kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 26.79MB 7.74kB ⬆️

@malwilley malwilley merged commit ff46507 into master May 14, 2024
43 checks passed
@malwilley malwilley deleted the malwilley/fix/search-tab-stops branch May 14, 2024 17:53
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants