Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate(related_issues): Drop support for doing all types of related issues #70606

Merged
merged 2 commits into from
May 13, 2024

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented May 9, 2024

This is a follow-up to #70504. Once the UI stops using this approach we will merge this change.

…d issues

This is a follow up to #70504. Once the UI stops using this approach we will merged this change.
@armenzg armenzg marked this pull request as ready for review May 9, 2024 19:31
@armenzg armenzg requested a review from a team as a code owner May 9, 2024 19:31
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.96%. Comparing base (f662031) to head (017eee0).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #70606      +/-   ##
==========================================
+ Coverage   78.09%   79.96%   +1.87%     
==========================================
  Files        6501     6501              
  Lines      290464   290464              
  Branches    50044    50041       -3     
==========================================
+ Hits       226846   232278    +5432     
+ Misses      63251    57819    -5432     
  Partials      367      367              
Files Coverage Δ
src/sentry/api/endpoints/issues/related_issues.py 100.00% <100.00%> (+29.16%) ⬆️
src/sentry/issues/related/__init__.py 100.00% <ø> (+41.66%) ⬆️

... and 436 files with indirect coverage changes

@armenzg armenzg merged commit 31ce316 into master May 13, 2024
49 checks passed
@armenzg armenzg deleted the feat/deprecate-old-approach/related_issues/armenzg branch May 13, 2024 12:12
Copy link

sentry-io bot commented May 13, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ MultiValueDictKeyError: 'type' /api/0/issues/{issue_id}/related-issues/ View Issue

Did you find this useful? React with a 👍 or 👎

@armenzg armenzg added the Trigger: Revert add to a merged PR to revert it (skips CI) label May 13, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: 590910f

getsentry-bot added a commit that referenced this pull request May 13, 2024
…f related issues (#70606)"

This reverts commit 31ce316.

Co-authored-by: armenzg <44410+armenzg@users.noreply.github.com>
armenzg added a commit that referenced this pull request May 14, 2024
…ed issues (#70793)

This is a follow-up to #70504.
Once the UI stops using this approach we will merge this change.

This got temporarily reverted in #70606 since we had to revert the UI
PR.
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants