chore(actor) Remove old actor columns #70549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for --
-- Custom state/database change combination
--
ALTER TABLE sentry_team DROP COLUMN actor_id;
ALTER TABLE sentry_rule DROP COLUMN owner_id;
ALTER TABLE sentry_alertrule DROP COLUMN owner_id;
ALTER TABLE sentry_grouphistory DROP COLUMN actor_id; |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #70549 +/- ##
==========================================
+ Coverage 76.99% 79.98% +2.98%
==========================================
Files 6496 6498 +2
Lines 290058 290232 +174
Branches 49979 50008 +29
==========================================
+ Hits 223340 232129 +8789
+ Misses 66349 57736 -8613
+ Partials 369 367 -2 |
|
PR reverted: cb038e9 |
getsentry-bot
added a commit
that referenced
this pull request
May 9, 2024
This reverts commit 1e5349e. Co-authored-by: markstory <24086+markstory@users.noreply.github.com>
markstory
added a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove now unused actor columns from rule, alertrule, team, grouphistory. These columns were removed from django state in #69784, #69873, #69976, #70090
Refs HC-1178