fix(replays): Fix 'clearQueryCache' method in 'useReplayData' hook #70539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
floels
force-pushed
the
fix-use-replay-data
branch
from
cd1ad07
to
fb801c8
Compare
floels
commented
May 8, 2024
| queryKey: [`/organizations/${orgSlug}/replays-events-meta/`], | ||
| }); | ||
| }; | ||
| queryClient.invalidateQueries({ |
There was a problem hiding this comment.
This is only removing the extraneous () => { on line 217 and the corresponding } on line 231.
ryan953
added
the
Trigger: getsentry tests
floels
changed the title
ryan953
reviewed
May 8, 2024
| @@ -32,10 +32,14 @@ jest.mocked(useProjects).mockReturnValue({ | |||
| placeholders: [], | |||
| }); | |||
|
|
|||
| const mockInvalidateQueries = jest.fn(); | |||
There was a problem hiding this comment.
Can we reset this before or after each test? This way if another test gets added the state from a previous test won't affect the new one.
There was a problem hiding this comment.
Ah yes good point, added in the existing beforeEach.
Fix a bug currently causing the 'clearQueryCache' method defined in 'static/app/utils/replays/hooks/useReplayData.tsx' to have no effect (extra arrow function declaration). Add a unit test to cover this behavior of the custom hook.
floels
force-pushed
the
fix-use-replay-data
branch
from
fb801c8
to
9944ba4
Compare
github-actions
bot
removed
the
Trigger: getsentry tests
ryan953
added
the
Trigger: getsentry tests
ryan953
approved these changes
May 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to fix a bug currently causing the
clearQueryCachemethod defined instatic/app/utils/replays/hooks/useReplayData.tsxto have no effect (extra arrow function declaration).Approach
Remove the duplicated arrow function declaration syntax (
() => { ... }).We also add a unit test to cover this behavior of the custom hook. You can see that the test fails if you revert the fix in
useReplayData.tsx.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.