Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(feedback): rm spam UI feature flag #70359

Merged
merged 2 commits into from May 14, 2024
Merged

chore(feedback): rm spam UI feature flag #70359

merged 2 commits into from May 14, 2024

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented May 6, 2024

closes #70346

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 6, 2024
@michellewzhang michellewzhang changed the title [do not merge yet] chore(feedback): rm spam UI feature flag [merge now] chore(feedback): rm spam UI feature flag May 13, 2024
@michellewzhang michellewzhang requested review from a team May 13, 2024 23:19
Comment on lines -1945 to -1946
# Enable User Feedback spam auto filtering feature UI
"organizations:user-feedback-spam-filter-ui": False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does spam filter work on self hosted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should, @JoshFerge just told me to remove the flags😶‍🌫️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need to write the docs for it still, but for now self hosted can mark things manually as spam

@michellewzhang michellewzhang changed the title [merge now] chore(feedback): rm spam UI feature flag chore(feedback): rm spam UI feature flag May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.01%. Comparing base (48d9c5c) to head (557b19b).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #70359   +/-   ##
=======================================
  Coverage   80.01%   80.01%           
=======================================
  Files        6505     6505           
  Lines      290794   290793    -1     
  Branches    50121    50121           
=======================================
  Hits       232684   232684           
+ Misses      57673    57672    -1     
  Partials      437      437           
Files Coverage Δ
src/sentry/conf/server.py 89.42% <ø> (ø)
src/sentry/features/temporary.py 100.00% <ø> (ø)

... and 7 files with indirect coverage changes

@michellewzhang michellewzhang merged commit 55f020b into master May 14, 2024
49 of 50 checks passed
@michellewzhang michellewzhang deleted the mz/spam-ff-be branch May 14, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[User Feedback] Enable 'Spam' ui inbox & buttons
3 participants