Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(feedback): show mark as spam buttons & spam mailbox for everyone #70353

Merged
merged 3 commits into from May 13, 2024

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented May 6, 2024

relates to #70346

shows the manual spam feature in these spots:

mailbox:
SCR-20240506-kuku

bulk action:
SCR-20240506-kumo

single feedback action:
SCR-20240506-kuom

@michellewzhang michellewzhang requested a review from a team as a code owner May 6, 2024 15:59
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 6, 2024
Copy link

codecov bot commented May 6, 2024

Bundle Report

Changes will increase total bundle size by 2.83kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 26.51MB 2.83kB ⬆️

@ryan953
Copy link
Member

ryan953 commented May 6, 2024

To start we should just flip the feature switch ( https://flagr.getsentry.net/#/flags/539) then we can remove the code afterwards

@michellewzhang michellewzhang changed the title chore(replay): show mark as spam buttons & spam mailbox for everyone [do not merge yet] chore(replay): show mark as spam buttons & spam mailbox for everyone May 6, 2024
@michellewzhang michellewzhang changed the title [do not merge yet] chore(replay): show mark as spam buttons & spam mailbox for everyone [do not merge yet] chore(feedback): show mark as spam buttons & spam mailbox for everyone May 6, 2024
@michellewzhang
Copy link
Member Author

To start we should just flip the feature switch ( https://flagr.getsentry.net/#/flags/539) then we can remove the code afterwards

just added all orgs to the flag in flagr

@ryan953 ryan953 changed the title [do not merge yet] chore(feedback): show mark as spam buttons & spam mailbox for everyone chore(feedback): show mark as spam buttons & spam mailbox for everyone May 13, 2024
@michellewzhang michellewzhang changed the title chore(feedback): show mark as spam buttons & spam mailbox for everyone [merge now] chore(feedback): show mark as spam buttons & spam mailbox for everyone May 13, 2024
@ryan953 ryan953 changed the title [merge now] chore(feedback): show mark as spam buttons & spam mailbox for everyone chore(feedback): show mark as spam buttons & spam mailbox for everyone May 13, 2024
@michellewzhang michellewzhang merged commit bef6fe8 into master May 13, 2024
47 of 48 checks passed
@michellewzhang michellewzhang deleted the mz/spam-ga branch May 13, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants