Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Remove lazy renderer component prop #69823

Merged
merged 6 commits into from Apr 29, 2024

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Apr 26, 2024

final follow up to #69740 prefer stable references to lazy()

The prop generics were more frustrating than i would've liked.

final follow up to #69740 prefer stable references to lazy()
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 26, 2024
@scttcper scttcper requested a review from a team April 29, 2024 18:40
@scttcper scttcper marked this pull request as ready for review April 29, 2024 18:40
@scttcper scttcper merged commit 67726bb into master Apr 29, 2024
43 checks passed
@scttcper scttcper deleted the scttcper/rm-lazy-component branch April 29, 2024 18:47
Copy link

sentry-io bot commented Apr 30, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: undefined is not an object (evaluating 'A[0].coord') <anonymous>(dist/sentry/chunks/app_views_releas... View Issue
  • ‼️ TypeError: undefined is not an object (evaluating 'H[K]') inner(echarts/lib/util/model) View Issue
  • ‼️ TypeError: undefined is not an object (evaluating 'u?.project.id') useFetchFeedbackData(app/components/feedback/us... View Issue
  • ‼️ NotFoundError: The object can not be found here. /settings/billing/checkout/ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants