Migration for all the model changes for Project Templates #69816

saponifi3d · 2024-04-26T21:51:53Z

Description

This will create 2 new models, ProjectTemplate and ProjectTemplateOptions. These models will be used to store settings across multiple projects. This PR also creates a 1 to 1 relationship for ProjectTemplates and Projects.

Design Document: https://www.notion.so/sentry/Service-Settings-Templates-ca6fdb38b15f4a6db61d319bc342b86c?pvs=4#60623e7fbaba4e0985f8d4581af18e64

src/sentry/models/projecttemplate.py

ceorourke · 2024-04-26T22:01:10Z

src/sentry/models/projecttemplate.py

+
+    class Meta:
+        app_label = "sentry"
+        db_table = "sentry_projecttemplate"


Does this need any unique together constraints like only 1 per org?

In this case, nope, we want to support multiple templates in an org. The feature use case is an organization wants to have a default template for their python backend services and their js FE services.

Should the names be unique per org?

oh snap, i did not read that very well. yeah, they should likely be unique names per org. thanks for the shout Colleen and the catch Dan!

ceorourke · 2024-04-26T22:01:49Z

src/sentry/models/project.py

@@ -245,6 +245,7 @@ class Project(Model, PendingDeletionMixin, OptionMixin, SnowflakeIdMixin):
    # projects that were created before this field was present
    # will have their first_event field set to date_added
    first_event = models.DateTimeField(null=True)
+    project_template = FlexibleForeignKey("sentry.ProjectTemplate", null=True)


Someone like Dan would know better than me but idk if you can add this and create the new table in one go

yeah, i wasn't sure if i should do all 3 model changes in 1 pr or in 3 PRs. I can ping dan and see if this makes sense.

fwiw the migration did work locally.. unclear if that means it'll work in prod or not though 😅

ah ha! it seems that django uses the operations key to decide the order it applies the migrations: https://github.com/getsentry/sentry/pull/69816/files#diff-705160f3302cfba81a9ad4b3182878d45a36c8a5f3f55d5be85d5ebde083e309R32 - since django automates all this they figured out the application order for me.

This is fine, you can add an FK and the table in the same migration

src/sentry/migrations/0707_project_template_models.py

github-actions · 2024-04-29T21:59:45Z

This PR has a migration; here is the generated SQL for src/sentry/migrations/0709_project_template_models.py ()

--
-- Create model ProjectTemplate
--
CREATE TABLE "sentry_projecttemplate" ("id" bigint NOT NULL PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY, "date_updated" timestamp with time zone NOT NULL, "date_added" timestamp with time zone NULL, "name" varchar(200) NOT NULL, "organization_id" bigint NOT NULL);
ALTER TABLE "sentry_projecttemplate" ADD CONSTRAINT "sentry_projecttempla_organization_id_b072f5c6_fk_sentry_or" FOREIGN KEY ("organization_id") REFERENCES "sentry_organization" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "sentry_projecttemplate" VALIDATE CONSTRAINT "sentry_projecttempla_organization_id_b072f5c6_fk_sentry_or";
CREATE INDEX CONCURRENTLY "sentry_projecttemplate_organization_id_b072f5c6" ON "sentry_projecttemplate" ("organization_id");
--
-- Add field template to project
--
ALTER TABLE "sentry_project" ADD COLUMN "template_id" bigint NULL;
--
-- Create model ProjectTemplateOption
--
CREATE TABLE "sentry_projecttemplateoption" ("id" bigint NOT NULL PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY, "key" varchar(64) NOT NULL, "value" text NOT NULL, "project_template_id" bigint NOT NULL);
ALTER TABLE "sentry_project" ADD CONSTRAINT "sentry_project_template_id_67f0bec7_fk_sentry_pr" FOREIGN KEY ("template_id") REFERENCES "sentry_projecttemplate" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "sentry_project" VALIDATE CONSTRAINT "sentry_project_template_id_67f0bec7_fk_sentry_pr";
CREATE INDEX CONCURRENTLY "sentry_project_template_id_67f0bec7" ON "sentry_project" ("template_id");
ALTER TABLE "sentry_projecttemplateoption" ADD CONSTRAINT "sentry_projecttempla_project_template_id_23fa7e71_fk_sentry_pr" FOREIGN KEY ("project_template_id") REFERENCES "sentry_projecttemplate" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "sentry_projecttemplateoption" VALIDATE CONSTRAINT "sentry_projecttempla_project_template_id_23fa7e71_fk_sentry_pr";
CREATE INDEX CONCURRENTLY "sentry_projecttemplateoption_project_template_id_23fa7e71" ON "sentry_projecttemplateoption" ("project_template_id");
--
-- Create constraint unique_projecttemplate_name_per_org on model projecttemplate
--
CREATE UNIQUE INDEX CONCURRENTLY "unique_projecttemplate_name_per_org" ON "sentry_projecttemplate" ("name", "organization_id");
ALTER TABLE "sentry_projecttemplate" ADD CONSTRAINT "unique_projecttemplate_name_per_org" UNIQUE USING INDEX "unique_projecttemplate_name_per_org";
--
-- Alter unique_together for projecttemplateoption (1 constraint(s))
--
CREATE UNIQUE INDEX CONCURRENTLY "sentry_projecttemplateop_project_template_id_key_87ae3e18_uniq" ON "sentry_projecttemplateoption" ("project_template_id", "key");
ALTER TABLE "sentry_projecttemplateoption" ADD CONSTRAINT "sentry_projecttemplateop_project_template_id_key_87ae3e18_uniq" UNIQUE USING INDEX "sentry_projecttemplateop_project_template_id_key_87ae3e18_uniq";

codecov · 2024-04-29T22:28:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.00%. Comparing base (2489a4a) to head (8fdf00e).
Report is 3 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #69816       +/-   ##
===========================================
+ Coverage   51.67%   80.00%   +28.32%     
===========================================
  Files        6460     6494       +34     
  Lines      288653   290026     +1373     
  Branches    49758    49963      +205     
===========================================
+ Hits       149164   232028    +82864     
+ Misses     139074    57587    -81487     
+ Partials      415      411        -4

Files	Coverage Δ
src/sentry/backup/comparators.py	`98.06% <ø> (+13.25%)`	⬆️
src/sentry/models/__init__.py	`100.00% <100.00%> (ø)`
src/sentry/models/options/__init__.py	`100.00% <100.00%> (ø)`
...c/sentry/models/options/project_template_option.py	`100.00% <100.00%> (ø)`
src/sentry/models/project.py	`97.35% <100.00%> (+49.01%)`	⬆️
src/sentry/models/projecttemplate.py	`100.00% <100.00%> (ø)`
src/sentry/testutils/helpers/backups.py	`99.70% <100.00%> (+2.35%)`	⬆️

... and 2084 files with indirect coverage changes

wedamija · 2024-04-30T00:13:35Z

src/sentry/models/projecttemplate.py

+
+    class Meta:
+        app_label = "sentry"
+        db_table = "sentry_projecttemplate"


Should the names be unique per org?

wedamija · 2024-04-30T00:13:57Z

src/sentry/models/project.py

@@ -245,6 +245,7 @@ class Project(Model, PendingDeletionMixin, OptionMixin, SnowflakeIdMixin):
    # projects that were created before this field was present
    # will have their first_event field set to date_added
    first_event = models.DateTimeField(null=True)
+    project_template = FlexibleForeignKey("sentry.ProjectTemplate", null=True)


This is fine, you can add an FK and the table in the same migration

wedamija · 2024-04-30T00:16:38Z

src/sentry/models/project.py

@@ -245,6 +245,7 @@ class Project(Model, PendingDeletionMixin, OptionMixin, SnowflakeIdMixin):
    # projects that were created before this field was present
    # will have their first_event field set to date_added
    first_event = models.DateTimeField(null=True)
+    project_template = FlexibleForeignKey("sentry.ProjectTemplate", null=True)


Might make sense as just template, otherwise we'll be calling project.project_template a lot

wedamija · 2024-04-30T00:17:38Z

src/sentry/migrations/0709_project_template_models.py

+    #   is a schema change, it's completely safe to run the operation after the code has deployed.
+    # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment
+
+    is_post_deployment = True


Schema changes can't be post deployment, this will take down sentry, as per the comment (this is the only blocking comment)

wedamija · 2024-04-30T00:19:57Z

tests/sentry/models/test_projecttemplateoption.py

+from sentry.testutils.cases import TestCase
+
+
+class ProjectTemplateOptionTest(TestCase):


It's up to you, but you don't really need to test that the ORM works

Yeah, agree. I just wanted to create a placeholder test for upcoming PRs :)

wedamija

migration lgtm

markstory · 2024-04-30T17:26:29Z

src/sentry/migrations/0709_project_template_models.py

+                        primary_key=True, serialize=False
+                    ),
+                ),
+                ("key", models.CharField(max_length=64)),


When querying this table will you always have project_template_id available? If not you'll need an index on key.

Yeah, we'll always need the project template id to select the settings. I don't see us needing queries like "what are all the values an organization has set in all of their templates" or "Get me all the values for email prefixes in my templates" -- the design right now is more that we'll apply these settings to a project when getting those options, or when directly manipulating the template itself.

markstory · 2024-04-30T17:26:52Z

src/sentry/models/options/project_template_option.py

+from sentry.db.models.fields import PickledObjectField
+
+
+@region_silo_only_model


Suggested change

@region_silo_only_model

@region_silo_model

This is in the process of being renamed.

markstory · 2024-04-30T17:27:57Z

src/sentry/models/options/project_template_option.py

+
+    project_template = FlexibleForeignKey("sentry.ProjectTemplate", related_name="options")
+    key = models.CharField(max_length=64)
+    value = PickledObjectField()


I'm not sure we should be adding more pickled data to our database. Using a text field with JSON encoded payloads would be an improvement over the current option schema.

The pickled field actually just uses json now, there was a project to convert it a while ago. Not sure why we never renamed it

Is there a fixed set of values, or some sort of schema, we expect for this field, or is it completely freeform? If it's the former, we should at least at add a doc comment with some details (see UserOption for inspiration).

Currently, it's freeform. We'll be aligning to a subset of project options and new template level options. Since it's not clear what options are going to be in the initial version (waiting on design for those areas), this is purposefully left open until we have a bit more clarity on those details.

I was pushing off that work until the model code has been merged, i kinda figured there'd be a lot of test updates / random things and wanted to keep the complexity of this pr as close to sql changes as possible.

src/sentry/models/projecttemplate.py

github-actions · 2024-04-30T23:25:29Z

This PR has a migration; here is the generated SQL for src/sentry/migrations/0710_project_template_models.py ()

--
-- Create model ProjectTemplate
--
CREATE TABLE "sentry_projecttemplate" ("id" bigint NOT NULL PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY, "date_updated" timestamp with time zone NOT NULL, "date_added" timestamp with time zone NULL, "name" varchar(200) NOT NULL, "organization_id" bigint NOT NULL);
ALTER TABLE "sentry_projecttemplate" ADD CONSTRAINT "sentry_projecttempla_organization_id_b072f5c6_fk_sentry_or" FOREIGN KEY ("organization_id") REFERENCES "sentry_organization" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "sentry_projecttemplate" VALIDATE CONSTRAINT "sentry_projecttempla_organization_id_b072f5c6_fk_sentry_or";
CREATE INDEX CONCURRENTLY "sentry_projecttemplate_organization_id_b072f5c6" ON "sentry_projecttemplate" ("organization_id");
--
-- Add field template to project
--
ALTER TABLE "sentry_project" ADD COLUMN "template_id" bigint NULL;
--
-- Create model ProjectTemplateOption
--
CREATE TABLE "sentry_projecttemplateoption" ("id" bigint NOT NULL PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY, "key" varchar(64) NOT NULL, "value" text NOT NULL, "project_template_id" bigint NOT NULL);
ALTER TABLE "sentry_project" ADD CONSTRAINT "sentry_project_template_id_67f0bec7_fk_sentry_pr" FOREIGN KEY ("template_id") REFERENCES "sentry_projecttemplate" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "sentry_project" VALIDATE CONSTRAINT "sentry_project_template_id_67f0bec7_fk_sentry_pr";
CREATE INDEX CONCURRENTLY "sentry_project_template_id_67f0bec7" ON "sentry_project" ("template_id");
ALTER TABLE "sentry_projecttemplateoption" ADD CONSTRAINT "sentry_projecttempla_project_template_id_23fa7e71_fk_sentry_pr" FOREIGN KEY ("project_template_id") REFERENCES "sentry_projecttemplate" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "sentry_projecttemplateoption" VALIDATE CONSTRAINT "sentry_projecttempla_project_template_id_23fa7e71_fk_sentry_pr";
CREATE INDEX CONCURRENTLY "sentry_projecttemplateoption_project_template_id_23fa7e71" ON "sentry_projecttemplateoption" ("project_template_id");
--
-- Create constraint unique_projecttemplate_name_per_org on model projecttemplate
--
CREATE UNIQUE INDEX CONCURRENTLY "unique_projecttemplate_name_per_org" ON "sentry_projecttemplate" ("name", "organization_id");
ALTER TABLE "sentry_projecttemplate" ADD CONSTRAINT "unique_projecttemplate_name_per_org" UNIQUE USING INDEX "unique_projecttemplate_name_per_org";
--
-- Alter unique_together for projecttemplateoption (1 constraint(s))
--
CREATE UNIQUE INDEX CONCURRENTLY "sentry_projecttemplateop_project_template_id_key_87ae3e18_uniq" ON "sentry_projecttemplateoption" ("project_template_id", "key");
ALTER TABLE "sentry_projecttemplateoption" ADD CONSTRAINT "sentry_projecttemplateop_project_template_id_key_87ae3e18_uniq" UNIQUE USING INDEX "sentry_projecttemplateop_project_template_id_key_87ae3e18_uniq";

github-actions · 2024-05-02T20:19:14Z

This PR has a migration; here is the generated SQL for src/sentry/migrations/0714_project_template_models.py ()

--
-- Create model ProjectTemplate
--
CREATE TABLE "sentry_projecttemplate" ("id" bigint NOT NULL PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY, "date_updated" timestamp with time zone NOT NULL, "date_added" timestamp with time zone NULL, "name" varchar(200) NOT NULL, "organization_id" bigint NOT NULL);
ALTER TABLE "sentry_projecttemplate" ADD CONSTRAINT "sentry_projecttempla_organization_id_b072f5c6_fk_sentry_or" FOREIGN KEY ("organization_id") REFERENCES "sentry_organization" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "sentry_projecttemplate" VALIDATE CONSTRAINT "sentry_projecttempla_organization_id_b072f5c6_fk_sentry_or";
CREATE INDEX CONCURRENTLY "sentry_projecttemplate_organization_id_b072f5c6" ON "sentry_projecttemplate" ("organization_id");
--
-- Add field template to project
--
ALTER TABLE "sentry_project" ADD COLUMN "template_id" bigint NULL;
--
-- Create model ProjectTemplateOption
--
CREATE TABLE "sentry_projecttemplateoption" ("id" bigint NOT NULL PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY, "key" varchar(64) NOT NULL, "value" text NOT NULL, "project_template_id" bigint NOT NULL);
ALTER TABLE "sentry_project" ADD CONSTRAINT "sentry_project_template_id_67f0bec7_fk_sentry_pr" FOREIGN KEY ("template_id") REFERENCES "sentry_projecttemplate" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "sentry_project" VALIDATE CONSTRAINT "sentry_project_template_id_67f0bec7_fk_sentry_pr";
CREATE INDEX CONCURRENTLY "sentry_project_template_id_67f0bec7" ON "sentry_project" ("template_id");
ALTER TABLE "sentry_projecttemplateoption" ADD CONSTRAINT "sentry_projecttempla_project_template_id_23fa7e71_fk_sentry_pr" FOREIGN KEY ("project_template_id") REFERENCES "sentry_projecttemplate" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "sentry_projecttemplateoption" VALIDATE CONSTRAINT "sentry_projecttempla_project_template_id_23fa7e71_fk_sentry_pr";
CREATE INDEX CONCURRENTLY "sentry_projecttemplateoption_project_template_id_23fa7e71" ON "sentry_projecttemplateoption" ("project_template_id");
--
-- Create constraint unique_projecttemplate_name_per_org on model projecttemplate
--
CREATE UNIQUE INDEX CONCURRENTLY "unique_projecttemplate_name_per_org" ON "sentry_projecttemplate" ("name", "organization_id");
ALTER TABLE "sentry_projecttemplate" ADD CONSTRAINT "unique_projecttemplate_name_per_org" UNIQUE USING INDEX "unique_projecttemplate_name_per_org";
--
-- Alter unique_together for projecttemplateoption (1 constraint(s))
--
CREATE UNIQUE INDEX CONCURRENTLY "sentry_projecttemplateop_project_template_id_key_87ae3e18_uniq" ON "sentry_projecttemplateoption" ("project_template_id", "key");
ALTER TABLE "sentry_projecttemplateoption" ADD CONSTRAINT "sentry_projecttemplateop_project_template_id_key_87ae3e18_uniq" UNIQUE USING INDEX "sentry_projecttemplateop_project_template_id_key_87ae3e18_uniq";

…t_template' to 'template' on the project model

…ted changing

…rectly for the future

github-actions · 2024-05-07T22:57:15Z

This PR has a migration; here is the generated SQL for src/sentry/migrations/0715_project_template_models.py ()

--
-- Create model ProjectTemplate
--
CREATE TABLE "sentry_projecttemplate" ("id" bigint NOT NULL PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY, "date_updated" timestamp with time zone NOT NULL, "date_added" timestamp with time zone NULL, "name" varchar(200) NOT NULL, "organization_id" bigint NOT NULL);
ALTER TABLE "sentry_projecttemplate" ADD CONSTRAINT "sentry_projecttempla_organization_id_b072f5c6_fk_sentry_or" FOREIGN KEY ("organization_id") REFERENCES "sentry_organization" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "sentry_projecttemplate" VALIDATE CONSTRAINT "sentry_projecttempla_organization_id_b072f5c6_fk_sentry_or";
CREATE INDEX CONCURRENTLY "sentry_projecttemplate_organization_id_b072f5c6" ON "sentry_projecttemplate" ("organization_id");
--
-- Add field template to project
--
ALTER TABLE "sentry_project" ADD COLUMN "template_id" bigint NULL;
--
-- Create model ProjectTemplateOption
--
CREATE TABLE "sentry_projecttemplateoption" ("id" bigint NOT NULL PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY, "key" varchar(64) NOT NULL, "value" text NOT NULL, "project_template_id" bigint NOT NULL);
ALTER TABLE "sentry_project" ADD CONSTRAINT "sentry_project_template_id_67f0bec7_fk_sentry_pr" FOREIGN KEY ("template_id") REFERENCES "sentry_projecttemplate" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "sentry_project" VALIDATE CONSTRAINT "sentry_project_template_id_67f0bec7_fk_sentry_pr";
CREATE INDEX CONCURRENTLY "sentry_project_template_id_67f0bec7" ON "sentry_project" ("template_id");
ALTER TABLE "sentry_projecttemplateoption" ADD CONSTRAINT "sentry_projecttempla_project_template_id_23fa7e71_fk_sentry_pr" FOREIGN KEY ("project_template_id") REFERENCES "sentry_projecttemplate" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "sentry_projecttemplateoption" VALIDATE CONSTRAINT "sentry_projecttempla_project_template_id_23fa7e71_fk_sentry_pr";
CREATE INDEX CONCURRENTLY "sentry_projecttemplateoption_project_template_id_23fa7e71" ON "sentry_projecttemplateoption" ("project_template_id");
--
-- Create constraint unique_projecttemplate_name_per_org on model projecttemplate
--
CREATE UNIQUE INDEX CONCURRENTLY "unique_projecttemplate_name_per_org" ON "sentry_projecttemplate" ("name", "organization_id");
ALTER TABLE "sentry_projecttemplate" ADD CONSTRAINT "unique_projecttemplate_name_per_org" UNIQUE USING INDEX "unique_projecttemplate_name_per_org";
--
-- Alter unique_together for projecttemplateoption (1 constraint(s))
--
CREATE UNIQUE INDEX CONCURRENTLY "sentry_projecttemplateop_project_template_id_key_87ae3e18_uniq" ON "sentry_projecttemplateoption" ("project_template_id", "key");
ALTER TABLE "sentry_projecttemplateoption" ADD CONSTRAINT "sentry_projecttemplateop_project_template_id_key_87ae3e18_uniq" UNIQUE USING INDEX "sentry_projecttemplateop_project_template_id_key_87ae3e18_uniq";

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 26, 2024

ceorourke reviewed Apr 26, 2024

View reviewed changes

src/sentry/models/projecttemplate.py Outdated Show resolved Hide resolved

ceorourke reviewed Apr 26, 2024

View reviewed changes

src/sentry/migrations/0707_project_template_models.py Outdated Show resolved Hide resolved

vercel bot deployed to Preview April 29, 2024 16:35 View deployment

saponifi3d force-pushed the jcallender/settings-templates-models branch from 5727491 to ff8d117 Compare April 29, 2024 21:57

vercel bot deployed to Preview April 29, 2024 21:59 View deployment

saponifi3d force-pushed the jcallender/settings-templates-models branch from ff8d117 to d4f4f00 Compare April 29, 2024 23:20

vercel bot deployed to Preview April 29, 2024 23:22 View deployment

vercel bot deployed to Preview April 29, 2024 23:57 View deployment

saponifi3d marked this pull request as ready for review April 30, 2024 00:06

saponifi3d requested review from a team as code owners April 30, 2024 00:06

wedamija requested changes Apr 30, 2024

View reviewed changes

vercel bot deployed to Preview April 30, 2024 16:25 View deployment

wedamija approved these changes Apr 30, 2024

View reviewed changes

vercel bot deployed to Preview April 30, 2024 17:17 View deployment

markstory reviewed Apr 30, 2024

View reviewed changes

vercel bot deployed to Preview April 30, 2024 23:07 View deployment

saponifi3d force-pushed the jcallender/settings-templates-models branch from a0f9de3 to f48f4e3 Compare April 30, 2024 23:22

vercel bot deployed to Preview April 30, 2024 23:25 View deployment

saponifi3d force-pushed the jcallender/settings-templates-models branch from f48f4e3 to 9fbef86 Compare May 2, 2024 18:29

vercel bot deployed to Preview May 2, 2024 18:31 View deployment

saponifi3d force-pushed the jcallender/settings-templates-models branch from 9fbef86 to a8593c1 Compare May 2, 2024 20:16

saponifi3d added 27 commits May 7, 2024 15:52

remove the OptionManager stuff for now

8960132

update the project model to have a fk to template

6014c10

register the new models

26f1aa6

create a migration for the model changes

8ba262f

Use the DefaultFieldsModel to ensure consistency with other models

74a68d7

make this a post deployment migration since it will affect every project

80e24ee

redo migration since there have been a few

fd3717d

add basic tests, these are mostly to help me later

801b604

Don't take down sentry.

78aac44

Add constraint to project template names for each org. Chnage 'projec…

2cd2aaa

…t_template' to 'template' on the project model

regenerate the migration based on the model changes

9221f01

region_silo_only_model -> region_silo_model

a57b8d6

Updating migration version

264b5bc

update to new migration

11ef559

resolve migration merge conflict

f381be0

fixtures and snapshot updates

0d8d02c

first pass at updating the helpers/backup.

a37b822

fix merge conflict with test clean pkgs.

d881d92

add freeze time to the sanitize test, this fixes issue with data_upda…

f3538d6

…ted changing

add a todo to make sure to go back and link the project templates cor…

e2b3300

…rectly for the future

update snapshot to fix test

e01ab4a

update snapshot

0ce6e96

update snapshot

ec204e2

update snapshots

3d6f0aa

ignore the date added field

f73382f

Update snapshot to use the compartor for date_updated and date_added

a2bf38f

Regenerate migration after merge conflict

8fdf00e

saponifi3d force-pushed the jcallender/settings-templates-models branch from 43dcaad to 8fdf00e Compare May 7, 2024 22:54

vercel bot deployed to Preview May 7, 2024 22:58 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migration for all the model changes for Project Templates #69816

Migration for all the model changes for Project Templates #69816

saponifi3d commented Apr 26, 2024

ceorourke Apr 26, 2024

saponifi3d Apr 26, 2024

wedamija Apr 30, 2024

saponifi3d Apr 30, 2024

ceorourke Apr 26, 2024

saponifi3d Apr 26, 2024

saponifi3d Apr 29, 2024

wedamija Apr 30, 2024

github-actions bot commented Apr 29, 2024 •

edited

codecov bot commented Apr 29, 2024 •

edited

wedamija Apr 30, 2024

wedamija Apr 30, 2024

wedamija Apr 30, 2024

wedamija Apr 30, 2024 •

edited

wedamija Apr 30, 2024

saponifi3d Apr 30, 2024

wedamija left a comment

markstory Apr 30, 2024

saponifi3d Apr 30, 2024

markstory Apr 30, 2024

markstory Apr 30, 2024

wedamija Apr 30, 2024

azaslavsky May 7, 2024

saponifi3d May 7, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented May 2, 2024

github-actions bot commented May 7, 2024

		from sentry.testutils.cases import TestCase


		class ProjectTemplateOptionTest(TestCase):

		from sentry.db.models.fields import PickledObjectField


		@region_silo_only_model

Migration for all the model changes for Project Templates #69816

Are you sure you want to change the base?

Migration for all the model changes for Project Templates #69816

Conversation

saponifi3d commented Apr 26, 2024

Description

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Apr 29, 2024 • edited

codecov bot commented Apr 29, 2024 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wedamija Apr 30, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wedamija left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Apr 30, 2024

github-actions bot commented May 2, 2024

github-actions bot commented May 7, 2024

github-actions bot commented Apr 29, 2024 •

edited

codecov bot commented Apr 29, 2024 •

edited

wedamija Apr 30, 2024 •

edited