fix(hybridcloud) Improve API gateway routing for error-embed #69815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The browser SDK is still creating URLs for the error-embed views using `sentry.io` for customers in all regions. Remove the error-embed view from the region pin list and create DSN based routing. I don't love this solution, but it should be robust enough to handle the scenarios that customers are having problems with. Refs HC-1182 Refs getsentry/sentry-javascript#11813
github-actions
bot
added
the
Scope: Backend
3 tasks
mrduncan
approved these changes
Apr 26, 2024
| try: | ||
| parsed = urlparse(dsn) | ||
| except Exception: | ||
| return None |
There was a problem hiding this comment.
Is it worth tracking all the return None cases with a metric or log entry?
|
|
||
| app_segments = app_host.split(".") | ||
| host_segments = host.split(".") | ||
| if len(host_segments) - len(app_segments) < 3: |
There was a problem hiding this comment.
Just to confirm, if we're running in monolith mode we'd never hit this code path? Thinking about the case for self-hosted where domains might be weird
There was a problem hiding this comment.
Yes, the apigateway middleware is only active when the application is in control mode.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browser SDK is still creating URLs for the error-embed views using
sentry.iofor customers in all regions. Remove the error-embed view from the region pin list and create DSN based routing. I don't love this solution, but it should be robust enough to handle the scenarios that customers are having problems with.Refs HC-1182
Refs getsentry/sentry-javascript#11813