New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hybridcloud) Improve API gateway routing for error-embed #69815
Conversation
The browser SDK is still creating URLs for the error-embed views using `sentry.io` for customers in all regions. Remove the error-embed view from the region pin list and create DSN based routing. I don't love this solution, but it should be robust enough to handle the scenarios that customers are having problems with. Refs HC-1182 Refs getsentry/sentry-javascript#11813
try: | ||
parsed = urlparse(dsn) | ||
except Exception: | ||
return None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth tracking all the return None
cases with a metric or log entry?
|
||
app_segments = app_host.split(".") | ||
host_segments = host.split(".") | ||
if len(host_segments) - len(app_segments) < 3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, if we're running in monolith mode we'd never hit this code path? Thinking about the case for self-hosted where domains might be weird
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the apigateway middleware is only active when the application is in control mode.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
The browser SDK is still creating URLs for the error-embed views using
sentry.io
for customers in all regions. Remove the error-embed view from the region pin list and create DSN based routing. I don't love this solution, but it should be robust enough to handle the scenarios that customers are having problems with.Refs HC-1182
Refs getsentry/sentry-javascript#11813