Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crons): Add stub consumers for clock tick / tasks #69809

Conversation

evanpurkhiser
Copy link
Member

We will use these to process clock ticks and their associated tasks

@evanpurkhiser evanpurkhiser requested review from a team as code owners April 26, 2024 21:04
@evanpurkhiser evanpurkhiser removed request for a team April 26, 2024 21:04
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 26, 2024
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/feat-crons-add-stub-consumers-for-clock-tick-tasks branch from b4cb063 to 4b6400b Compare April 26, 2024 21:19
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/feat-crons-add-stub-consumers-for-clock-tick-tasks branch from 4b6400b to 8b73213 Compare April 26, 2024 21:50
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 79.84%. Comparing base (aed6fb4) to head (8b73213).
Report is 1 commits behind head on master.

❗ Current head 8b73213 differs from pull request most recent head 6444c3e. Consider uploading reports for the commit 6444c3e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #69809      +/-   ##
==========================================
+ Coverage   76.95%   79.84%   +2.89%     
==========================================
  Files        6487     6488       +1     
  Lines      288480   288308     -172     
  Branches    49684    49667      -17     
==========================================
+ Hits       221988   230198    +8210     
+ Misses      65950    57708    -8242     
+ Partials      542      402     -140     
Files Coverage Δ
src/sentry/conf/server.py 89.18% <ø> (ø)
src/sentry/conf/types/kafka_definition.py 100.00% <100.00%> (ø)
src/sentry/consumers/__init__.py 83.33% <ø> (ø)
.../sentry/monitors/consumers/clock_tasks_consumer.py 84.61% <84.61%> (ø)
...c/sentry/monitors/consumers/clock_tick_consumer.py 84.61% <84.61%> (ø)

... and 536 files with indirect coverage changes

We will use these to process clock ticks and their associated tasks
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/feat-crons-add-stub-consumers-for-clock-tick-tasks branch from 8b73213 to 6444c3e Compare April 29, 2024 16:43
@evanpurkhiser evanpurkhiser merged commit 2c12dad into master Apr 29, 2024
49 of 50 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/feat-crons-add-stub-consumers-for-clock-tick-tasks branch April 29, 2024 17:48
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants