Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Use the same version of Clickhouse as SaaS #69794

Merged
merged 1 commit into from Apr 29, 2024

Conversation

evanh
Copy link
Member

@evanh evanh commented Apr 26, 2024

This is the version of Clickhouse that runs internally, so it should be tested locally as well.

Also checked on the ARM support, and based on this comment: ClickHouse/ClickHouse#22222 (comment) it looks like ARM is supported by default now.

This is the version of Clickhouse that runs internally, so it should be tested
locally as well.

Also checked on the ARM support, and based on this comment: ClickHouse/ClickHouse#22222 (comment)
it looks like ARM is supported by default now.
@evanh evanh requested a review from a team April 26, 2024 18:50
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 26, 2024
Copy link
Member

@volokluev volokluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.82%. Comparing base (4bffd8a) to head (f5d4bb1).
Report is 32 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #69794    +/-   ##
========================================
  Coverage   79.81%   79.82%            
========================================
  Files        6480     6483     +3     
  Lines      288099   288292   +193     
  Branches    49643    49672    +29     
========================================
+ Hits       229945   230123   +178     
- Misses      57762    57777    +15     
  Partials      392      392            
Files Coverage Δ
src/sentry/conf/server.py 89.18% <ø> (ø)

... and 37 files with indirect coverage changes

@evanh evanh merged commit ae8ec69 into master Apr 29, 2024
50 checks passed
@evanh evanh deleted the evanh/fix/use-22.8-in-sentry branch April 29, 2024 13:58
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants